From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Ghiti Date: Wed, 19 Jun 2019 05:54:20 +0000 Subject: Re: [PATCH RESEND 1/8] s390: Start fallback of top-down mmap at mm->mmap_base Message-Id: <4fcd8c83-dc33-12ab-3ba2-85a8d851674d@ghiti.fr> List-Id: References: <20190619054224.5983-1-alex@ghiti.fr> <20190619054224.5983-2-alex@ghiti.fr> In-Reply-To: <20190619054224.5983-2-alex@ghiti.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexandre Ghiti Cc: "James E . J . Bottomley" , Helge Deller , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Yoshinori Sato , Rich Felker , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, Andrew Morton Really sorry about that, my connection is weird this morning, I'll retry tomorrow. Sorry again, Alex On 6/19/19 1:42 AM, Alexandre Ghiti wrote: > In case of mmap failure in top-down mode, there is no need to go through > the whole address space again for the bottom-up fallback: the goal of this > fallback is to find, as a last resort, space between the top-down mmap base > and the stack, which is the only place not covered by the top-down mmap. > > Signed-off-by: Alexandre Ghiti > --- > arch/s390/mm/mmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/mm/mmap.c b/arch/s390/mm/mmap.c > index cbc718ba6d78..4a222969843b 100644 > --- a/arch/s390/mm/mmap.c > +++ b/arch/s390/mm/mmap.c > @@ -166,7 +166,7 @@ arch_get_unmapped_area_topdown(struct file *filp, const unsigned long addr0, > if (addr & ~PAGE_MASK) { > VM_BUG_ON(addr != -ENOMEM); > info.flags = 0; > - info.low_limit = TASK_UNMAPPED_BASE; > + info.low_limit = mm->mmap_base; > info.high_limit = TASK_SIZE; > addr = vm_unmapped_area(&info); > if (addr & ~PAGE_MASK) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A36E4C31E49 for ; Wed, 19 Jun 2019 05:54:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D3A8208CB for ; Wed, 19 Jun 2019 05:54:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725899AbfFSFyh (ORCPT ); Wed, 19 Jun 2019 01:54:37 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:39059 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbfFSFyh (ORCPT ); Wed, 19 Jun 2019 01:54:37 -0400 X-Originating-IP: 79.86.19.127 Received: from [192.168.0.12] (127.19.86.79.rev.sfr.net [79.86.19.127]) (Authenticated sender: alex@ghiti.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id E2F4DE000E; Wed, 19 Jun 2019 05:54:21 +0000 (UTC) From: Alex Ghiti To: Alexandre Ghiti Cc: "James E . J . Bottomley" , Helge Deller , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Yoshinori Sato , Rich Felker , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, Andrew Morton Subject: Re: [PATCH RESEND 1/8] s390: Start fallback of top-down mmap at mm->mmap_base References: <20190619054224.5983-1-alex@ghiti.fr> <20190619054224.5983-2-alex@ghiti.fr> Message-ID: <4fcd8c83-dc33-12ab-3ba2-85a8d851674d@ghiti.fr> Date: Wed, 19 Jun 2019 01:54:20 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190619054224.5983-2-alex@ghiti.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org Really sorry about that, my connection is weird this morning, I'll retry tomorrow. Sorry again, Alex On 6/19/19 1:42 AM, Alexandre Ghiti wrote: > In case of mmap failure in top-down mode, there is no need to go through > the whole address space again for the bottom-up fallback: the goal of this > fallback is to find, as a last resort, space between the top-down mmap base > and the stack, which is the only place not covered by the top-down mmap. > > Signed-off-by: Alexandre Ghiti > --- > arch/s390/mm/mmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/mm/mmap.c b/arch/s390/mm/mmap.c > index cbc718ba6d78..4a222969843b 100644 > --- a/arch/s390/mm/mmap.c > +++ b/arch/s390/mm/mmap.c > @@ -166,7 +166,7 @@ arch_get_unmapped_area_topdown(struct file *filp, const unsigned long addr0, > if (addr & ~PAGE_MASK) { > VM_BUG_ON(addr != -ENOMEM); > info.flags = 0; > - info.low_limit = TASK_UNMAPPED_BASE; > + info.low_limit = mm->mmap_base; > info.high_limit = TASK_SIZE; > addr = vm_unmapped_area(&info); > if (addr & ~PAGE_MASK)