From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55B96C433E6 for ; Tue, 12 Jan 2021 11:01:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12ED92310E for ; Tue, 12 Jan 2021 11:01:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729421AbhALLBQ (ORCPT ); Tue, 12 Jan 2021 06:01:16 -0500 Received: from foss.arm.com ([217.140.110.172]:43970 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725922AbhALLBP (ORCPT ); Tue, 12 Jan 2021 06:01:15 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 950FC1042; Tue, 12 Jan 2021 03:00:29 -0800 (PST) Received: from [192.168.178.6] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B980C3F66E; Tue, 12 Jan 2021 03:00:24 -0800 (PST) Subject: Re: [RFC PATCH v3 0/2] scheduler: expose the topology of clusters and add cluster scheduler To: Morten Rasmussen , Tim Chen Cc: Barry Song , valentin.schneider@arm.com, catalin.marinas@arm.com, will@kernel.org, rjw@rjwysocki.net, vincent.guittot@linaro.org, lenb@kernel.org, gregkh@linuxfoundation.org, jonathan.cameron@huawei.com, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, mark.rutland@arm.com, sudeep.holla@arm.com, aubrey.li@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linuxarm@openeuler.org, xuwei5@huawei.com, prime.zeng@hisilicon.com, tiantao6@hisilicon.com References: <20210106083026.40444-1-song.bao.hua@hisilicon.com> <737932c9-846a-0a6b-08b8-e2d2d95b67ce@linux.intel.com> <20210108151241.GA47324@e123083-lin> <99c07bdf-02d1-153a-bd1e-2f4200cc67c5@linux.intel.com> <20210111092811.GB47324@e123083-lin> From: Dietmar Eggemann Message-ID: <4fdc781e-7385-2ae6-d9c9-3ec165f473c4@arm.com> Date: Tue, 12 Jan 2021 12:00:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210111092811.GB47324@e123083-lin> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 11/01/2021 10:28, Morten Rasmussen wrote: > On Fri, Jan 08, 2021 at 12:22:41PM -0800, Tim Chen wrote: >> >> >> On 1/8/21 7:12 AM, Morten Rasmussen wrote: >>> On Thu, Jan 07, 2021 at 03:16:47PM -0800, Tim Chen wrote: >>>> On 1/6/21 12:30 AM, Barry Song wrote: [...] >> I think it is going to depend on the workload. If there are dependent >> tasks that communicate with one another, putting them together >> in the same cluster will be the right thing to do to reduce communication >> costs. On the other hand, if the tasks are independent, putting them together on the same cluster >> will increase resource contention and spreading them out will be better. > > Agree. That is exactly where I'm coming from. This is all about the task > placement policy. We generally tend to spread tasks to avoid resource > contention, SMT and caches, which seems to be what you are proposing to > extend. I think that makes sense given it can produce significant > benefits. > >> >> Any thoughts on what is the right clustering "tag" to use to clump >> related tasks together? >> Cgroup? Pid? Tasks with same mm? > > I think this is the real question. I think the closest thing we have at > the moment is the wakee/waker flip heuristic. This seems to be related. > Perhaps the wake_affine tricks can serve as starting point? wake_wide() switches between packing (select_idle_sibling(), llc_size CPUs) and spreading (find_idlest_cpu(), all CPUs). AFAICS, since none of the sched domains set SD_BALANCE_WAKE, currently all wakeups are (llc-)packed. select_task_rq_fair() for_each_domain(cpu, tmp) if (tmp->flags & sd_flag) sd = tmp; In case we would like to further distinguish between llc-packing and even narrower (cluster or MC-L2)-packing, we would introduce a 2. level packing vs. spreading heuristic further down in sis(). IMHO, Barry's current implementation doesn't do this right now. Instead he's trying to pack on cluster first and if not successful look further among the remaining llc CPUs for an idle CPU. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 847B7C433DB for ; Tue, 12 Jan 2021 11:02:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 358A62310C for ; Tue, 12 Jan 2021 11:02:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 358A62310C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=b73TZtqDNICkrDtn9I9PrvM6FxAiC3aoNMsq27qN+zI=; b=r/WYrjWCf/dXid1tPewWnX9E7 cGMRDxRwASgq5Ejl34NXyASJsTSiBFtIBvqTC2D5LaGsdKZVC5iaMxgVTkAeb04rbHHOsStbguYTk uozJxZEIRIHVS59CIZK8DL+tZGPf3SJYNr46WrKyo+VQlp4oLUNdold6luu7WFOU7Rv+ChHwpKgb6 3DzF/m8G6EOToRmqPIqLBAYGFun+mDyFZl4MwE4gbQFEJhfMu6V9rgqmmuLcEMn8Ku8tZul1UTPWV kPYMe6NG9r9OSF94nO+b2kqEtmMOZStrMqDHlW25vRxUNRtDZvyG4bJqhRHebUDNRcB+cRm0WplZd Ly1TmXNBg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzHPi-0006ht-Nj; Tue, 12 Jan 2021 11:00:38 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzHPe-0006fg-F5 for linux-arm-kernel@lists.infradead.org; Tue, 12 Jan 2021 11:00:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 950FC1042; Tue, 12 Jan 2021 03:00:29 -0800 (PST) Received: from [192.168.178.6] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B980C3F66E; Tue, 12 Jan 2021 03:00:24 -0800 (PST) Subject: Re: [RFC PATCH v3 0/2] scheduler: expose the topology of clusters and add cluster scheduler To: Morten Rasmussen , Tim Chen References: <20210106083026.40444-1-song.bao.hua@hisilicon.com> <737932c9-846a-0a6b-08b8-e2d2d95b67ce@linux.intel.com> <20210108151241.GA47324@e123083-lin> <99c07bdf-02d1-153a-bd1e-2f4200cc67c5@linux.intel.com> <20210111092811.GB47324@e123083-lin> From: Dietmar Eggemann Message-ID: <4fdc781e-7385-2ae6-d9c9-3ec165f473c4@arm.com> Date: Tue, 12 Jan 2021 12:00:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210111092811.GB47324@e123083-lin> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210112_060034_599958_D2794D40 X-CRM114-Status: GOOD ( 21.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: juri.lelli@redhat.com, mark.rutland@arm.com, peterz@infradead.org, catalin.marinas@arm.com, bsegall@google.com, xuwei5@huawei.com, will@kernel.org, vincent.guittot@linaro.org, aubrey.li@linux.intel.com, linux-acpi@vger.kernel.org, mingo@redhat.com, mgorman@suse.de, valentin.schneider@arm.com, lenb@kernel.org, linuxarm@openeuler.org, rostedt@goodmis.org, prime.zeng@hisilicon.com, jonathan.cameron@huawei.com, linux-arm-kernel@lists.infradead.org, Barry Song , gregkh@linuxfoundation.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, sudeep.holla@arm.com, tiantao6@hisilicon.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/01/2021 10:28, Morten Rasmussen wrote: > On Fri, Jan 08, 2021 at 12:22:41PM -0800, Tim Chen wrote: >> >> >> On 1/8/21 7:12 AM, Morten Rasmussen wrote: >>> On Thu, Jan 07, 2021 at 03:16:47PM -0800, Tim Chen wrote: >>>> On 1/6/21 12:30 AM, Barry Song wrote: [...] >> I think it is going to depend on the workload. If there are dependent >> tasks that communicate with one another, putting them together >> in the same cluster will be the right thing to do to reduce communication >> costs. On the other hand, if the tasks are independent, putting them together on the same cluster >> will increase resource contention and spreading them out will be better. > > Agree. That is exactly where I'm coming from. This is all about the task > placement policy. We generally tend to spread tasks to avoid resource > contention, SMT and caches, which seems to be what you are proposing to > extend. I think that makes sense given it can produce significant > benefits. > >> >> Any thoughts on what is the right clustering "tag" to use to clump >> related tasks together? >> Cgroup? Pid? Tasks with same mm? > > I think this is the real question. I think the closest thing we have at > the moment is the wakee/waker flip heuristic. This seems to be related. > Perhaps the wake_affine tricks can serve as starting point? wake_wide() switches between packing (select_idle_sibling(), llc_size CPUs) and spreading (find_idlest_cpu(), all CPUs). AFAICS, since none of the sched domains set SD_BALANCE_WAKE, currently all wakeups are (llc-)packed. select_task_rq_fair() for_each_domain(cpu, tmp) if (tmp->flags & sd_flag) sd = tmp; In case we would like to further distinguish between llc-packing and even narrower (cluster or MC-L2)-packing, we would introduce a 2. level packing vs. spreading heuristic further down in sis(). IMHO, Barry's current implementation doesn't do this right now. Instead he's trying to pack on cluster first and if not successful look further among the remaining llc CPUs for an idle CPU. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel