All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Nolan Leake <nolan@sigbus.net>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Andrew Baumann <Andrew.Baumann@microsoft.com>
Subject: Re: [PATCH v3] Add basic power management to raspi.
Date: Sat, 26 Jun 2021 12:16:01 +0200	[thread overview]
Message-ID: <4fe1c908-6d2e-8481-81c6-2c68c367e5e3@amsat.org> (raw)
In-Reply-To: <20210625210209.1870217-1-nolan@sigbus.net>

Hi Nolan, Peter,

On 6/25/21 11:02 PM, Nolan Leake wrote:
> This is just enough to make reboot and poweroff work. Works for
> linux, u-boot, and the arm trusted firmware. Not tested, but should
> work for plan9, and bare-metal/hobby OSes, since they seem to generally
> do what linux does for reset.
> 
> The watchdog timer functionality is not yet implemented.
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/64

Please carry the tags from previous versions (if the changes are minor).

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> Signed-off-by: Nolan Leake <nolan@sigbus.net>
> ---
>  hw/arm/bcm2835_peripherals.c         |  13 ++-
>  hw/misc/bcm2835_powermgt.c           | 160 +++++++++++++++++++++++++++
>  hw/misc/meson.build                  |   1 +
>  include/hw/arm/bcm2835_peripherals.h |   3 +-
>  include/hw/misc/bcm2835_powermgt.h   |  29 +++++
>  5 files changed, 204 insertions(+), 2 deletions(-)
>  create mode 100644 hw/misc/bcm2835_powermgt.c
>  create mode 100644 include/hw/misc/bcm2835_powermgt.h
> 
> diff --git hw/arm/bcm2835_peripherals.c hw/arm/bcm2835_peripherals.c

Odd, usually the diff line comes with a/ b/ prefix, I can not
apply your patch (git version 2.31.1, Fedora):

Applying: Add basic power management to raspi.
error: arm/bcm2835_peripherals.c: does not exist in index
error: misc/meson.build: does not exist in index
error: hw/arm/bcm2835_peripherals.h: does not exist in index
Patch failed at 0001 Add basic power management to raspi.

But patchew succeeded:
https://patchew.org/QEMU/20210625210209.1870217-1-nolan@sigbus.net/

Applying: Add basic power management to raspi.
Using index info to reconstruct a base tree...
A       arm/bcm2835_peripherals.c
A       hw/arm/bcm2835_peripherals.h
A       misc/meson.build
Falling back to patching base and 3-way merge...

So I tested patchew's commit 7856ac0e804:
https://github.com/patchew-project/qemu/commit/7856ac0e8045d006f1008a03e1d4d8710b9d0612

Peter, when queueing this patch (maybe prepending hw/arm: or
hw/arm/raspi: to the subject), can you take the corresponding
test along - which is already reviewed?
https://www.mail-archive.com/qemu-devel@nongnu.org/msg811909.html

Thanks both,

Phil.


  reply	other threads:[~2021-06-26 10:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25 21:02 [PATCH v3] Add basic power management to raspi Nolan Leake
2021-06-26 10:16 ` Philippe Mathieu-Daudé [this message]
2021-06-28 17:38   ` Peter Maydell
2021-06-29  7:46     ` Philippe Mathieu-Daudé
2021-06-29 15:47       ` Nolan
2021-06-26 17:33 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fe1c908-6d2e-8481-81c6-2c68c367e5e3@amsat.org \
    --to=f4bug@amsat.org \
    --cc=Andrew.Baumann@microsoft.com \
    --cc=nolan@sigbus.net \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.