From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Jilin Yuan <yuanjilin@cdjrlc.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>
Cc: <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] orinoco: fix repeated words in comments
Date: Wed, 14 Sep 2022 22:13:57 -0700 [thread overview]
Message-ID: <4fe4736d-ccc2-de00-8bb0-992382644fe6@quicinc.com> (raw)
In-Reply-To: <caf04e03-6cf3-5f56-da0b-ab68d58e7409@quicinc.com>
On 9/14/2022 8:54 PM, Jeff Johnson wrote:
> On 9/14/2022 8:02 PM, Jilin Yuan wrote:
>> Delete the redundant word 'this'.
>>
>> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
>> ---
>> drivers/net/wireless/intersil/orinoco/main.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/intersil/orinoco/main.h
>> b/drivers/net/wireless/intersil/orinoco/main.h
>> index 5a8fec26136e..852e1643dad2 100644
>> --- a/drivers/net/wireless/intersil/orinoco/main.h
>> +++ b/drivers/net/wireless/intersil/orinoco/main.h
>> @@ -12,7 +12,7 @@
>> /* Compile time configuration and compatibility stuff */
>> /********************************************************************/
>> -/* We do this this way to avoid ifdefs in the actual code */
>> +/* We do this way to avoid ifdefs in the actual code */
>
> In this case the two instances of "this" are not a repetition, they are
> different parts of speech.
>
> The existing sentence is correct English; the modified sentence is not.
>
> If the repeated word really bothers you then insert "in": We do this in
> this way...
>
>
>> #ifdef WIRELESS_SPY
>> #define SPY_NUMBER(priv) (priv->spy_data.spy_number)
>> #else
>
In addition the patch subject of all files in drivers/net/wireless
should now begin with "wifi: "
prev parent reply other threads:[~2022-09-15 5:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 3:02 [PATCH] orinoco: fix repeated words in comments Jilin Yuan
2022-09-15 3:54 ` Jeff Johnson
2022-09-15 5:13 ` Jeff Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fe4736d-ccc2-de00-8bb0-992382644fe6@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yuanjilin@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.