* [PATCH] drivers/virtio: Enable virtio mem for ARM64
@ 2022-01-18 1:34 Gavin Shan
2022-01-18 8:38 ` David Hildenbrand
0 siblings, 1 reply; 6+ messages in thread
From: Gavin Shan @ 2022-01-18 1:34 UTC (permalink / raw)
To: virtualization; +Cc: shan.gavin
This enables virtio-mem device support by allowing to enable the
corresponding kernel config option (CONFIG_VIRTIO_MEM) on the
architecture.
Signed-off-by: Gavin Shan <gshan@redhat.com>
---
drivers/virtio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index 34f80b7a8a64..bf3f6ebdaa3b 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig
@@ -106,7 +106,7 @@ config VIRTIO_BALLOON
config VIRTIO_MEM
tristate "Virtio mem driver"
default m
- depends on X86_64
+ depends on X86_64 || ARM64
depends on VIRTIO
depends on MEMORY_HOTPLUG
depends on MEMORY_HOTREMOVE
--
2.23.0
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/virtio: Enable virtio mem for ARM64
2022-01-18 1:34 [PATCH] drivers/virtio: Enable virtio mem for ARM64 Gavin Shan
@ 2022-01-18 8:38 ` David Hildenbrand
2022-01-18 8:42 ` Gavin Shan
2022-01-18 10:43 ` Michael S. Tsirkin
0 siblings, 2 replies; 6+ messages in thread
From: David Hildenbrand @ 2022-01-18 8:38 UTC (permalink / raw)
To: Gavin Shan, virtualization
Cc: Michael S . Tsirkin, shan.gavin, Jonathan Cameron
On 18.01.22 02:34, Gavin Shan wrote:
> This enables virtio-mem device support by allowing to enable the
> corresponding kernel config option (CONFIG_VIRTIO_MEM) on the
> architecture.
>
> Signed-off-by: Gavin Shan <gshan@redhat.com>
> ---
> drivers/virtio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index 34f80b7a8a64..bf3f6ebdaa3b 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -106,7 +106,7 @@ config VIRTIO_BALLOON
> config VIRTIO_MEM
> tristate "Virtio mem driver"
> default m
> - depends on X86_64
> + depends on X86_64 || ARM64
> depends on VIRTIO
> depends on MEMORY_HOTPLUG
> depends on MEMORY_HOTREMOVE
With MEMBLOCK_DRIVER_MANAGED in place upstream, kexec should be fine.
Can you adjust/rephrase the comment as well? Like
diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index 34f80b7a8a64..88028ca01c8f 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig
@@ -116,8 +116,9 @@ config VIRTIO_MEM
This driver provides access to virtio-mem paravirtualized memory
devices, allowing to hotplug and hotunplug memory.
- This driver was only tested under x86-64, but should theoretically
- work on all architectures that support memory hotplug and hotremove.
+ This driver was only tested under x86-64 and arm64, but should
+ theoretically work on all architectures that support memory hotplug and
+ hotremove.
If unsure, say M.
Acked-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/virtio: Enable virtio mem for ARM64
2022-01-18 8:38 ` David Hildenbrand
@ 2022-01-18 8:42 ` Gavin Shan
[not found] ` <20220118092249.0000358c@Huawei.com>
2022-01-18 10:43 ` Michael S. Tsirkin
1 sibling, 1 reply; 6+ messages in thread
From: Gavin Shan @ 2022-01-18 8:42 UTC (permalink / raw)
To: David Hildenbrand, virtualization
Cc: Michael S . Tsirkin, shan.gavin, Jonathan Cameron
On 1/18/22 4:38 PM, David Hildenbrand wrote:
> On 18.01.22 02:34, Gavin Shan wrote:
>> This enables virtio-mem device support by allowing to enable the
>> corresponding kernel config option (CONFIG_VIRTIO_MEM) on the
>> architecture.
>>
>> Signed-off-by: Gavin Shan <gshan@redhat.com>
>> ---
>> drivers/virtio/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
>> index 34f80b7a8a64..bf3f6ebdaa3b 100644
>> --- a/drivers/virtio/Kconfig
>> +++ b/drivers/virtio/Kconfig
>> @@ -106,7 +106,7 @@ config VIRTIO_BALLOON
>> config VIRTIO_MEM
>> tristate "Virtio mem driver"
>> default m
>> - depends on X86_64
>> + depends on X86_64 || ARM64
>> depends on VIRTIO
>> depends on MEMORY_HOTPLUG
>> depends on MEMORY_HOTREMOVE
>
> With MEMBLOCK_DRIVER_MANAGED in place upstream, kexec should be fine.
>
>
> Can you adjust/rephrase the comment as well? Like
>
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index 34f80b7a8a64..88028ca01c8f 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -116,8 +116,9 @@ config VIRTIO_MEM
> This driver provides access to virtio-mem paravirtualized memory
> devices, allowing to hotplug and hotunplug memory.
>
> - This driver was only tested under x86-64, but should theoretically
> - work on all architectures that support memory hotplug and hotremove.
> + This driver was only tested under x86-64 and arm64, but should
> + theoretically work on all architectures that support memory hotplug and
> + hotremove.
>
> If unsure, say M.
>
>
>
> Acked-by: David Hildenbrand <david@redhat.com>
>
Yup, It was obviously missed from the original patch. v2 will include the changes.
Thanks,
Gavin
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/virtio: Enable virtio mem for ARM64
[not found] ` <20220118092249.0000358c@Huawei.com>
@ 2022-01-18 9:33 ` Gavin Shan
0 siblings, 0 replies; 6+ messages in thread
From: Gavin Shan @ 2022-01-18 9:33 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: virtualization, Michael S . Tsirkin, shan.gavin
On 1/18/22 5:22 PM, Jonathan Cameron wrote:
> On Tue, 18 Jan 2022 16:42:55 +0800
> Gavin Shan <gshan@redhat.com> wrote:
>
>> On 1/18/22 4:38 PM, David Hildenbrand wrote:
>>> On 18.01.22 02:34, Gavin Shan wrote:
>>>> This enables virtio-mem device support by allowing to enable the
>>>> corresponding kernel config option (CONFIG_VIRTIO_MEM) on the
>>>> architecture.
>>>>
>>>> Signed-off-by: Gavin Shan <gshan@redhat.com>
>
> Probably wroth a +CC for linux-arm-kernel@lists.infradead.org
> so a wider crowd have visibility.
>
Yes, but v2 was posted. Let me reply to v2 to include
linux-arm-kernel@lists.infradead.org.
Thanks,
Gavin
>>>> ---
>>>> drivers/virtio/Kconfig | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
>>>> index 34f80b7a8a64..bf3f6ebdaa3b 100644
>>>> --- a/drivers/virtio/Kconfig
>>>> +++ b/drivers/virtio/Kconfig
>>>> @@ -106,7 +106,7 @@ config VIRTIO_BALLOON
>>>> config VIRTIO_MEM
>>>> tristate "Virtio mem driver"
>>>> default m
>>>> - depends on X86_64
>>>> + depends on X86_64 || ARM64
>>>> depends on VIRTIO
>>>> depends on MEMORY_HOTPLUG
>>>> depends on MEMORY_HOTREMOVE
>>>
>>> With MEMBLOCK_DRIVER_MANAGED in place upstream, kexec should be fine.
>>>
>>>
>>> Can you adjust/rephrase the comment as well? Like
>>>
>>> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
>>> index 34f80b7a8a64..88028ca01c8f 100644
>>> --- a/drivers/virtio/Kconfig
>>> +++ b/drivers/virtio/Kconfig
>>> @@ -116,8 +116,9 @@ config VIRTIO_MEM
>>> This driver provides access to virtio-mem paravirtualized memory
>>> devices, allowing to hotplug and hotunplug memory.
>>>
>>> - This driver was only tested under x86-64, but should theoretically
>>> - work on all architectures that support memory hotplug and hotremove.
>>> + This driver was only tested under x86-64 and arm64, but should
>>> + theoretically work on all architectures that support memory hotplug and
>>> + hotremove.
>>>
>>> If unsure, say M.
>>>
>>>
>>>
>>> Acked-by: David Hildenbrand <david@redhat.com>
>>>
>>
>> Yup, It was obviously missed from the original patch. v2 will include the changes.
>>
>> Thanks,
>> Gavin
>>
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/virtio: Enable virtio mem for ARM64
2022-01-18 8:38 ` David Hildenbrand
2022-01-18 8:42 ` Gavin Shan
@ 2022-01-18 10:43 ` Michael S. Tsirkin
2022-01-18 10:48 ` David Hildenbrand
1 sibling, 1 reply; 6+ messages in thread
From: Michael S. Tsirkin @ 2022-01-18 10:43 UTC (permalink / raw)
To: David Hildenbrand; +Cc: Jonathan Cameron, shan.gavin, virtualization
On Tue, Jan 18, 2022 at 09:38:21AM +0100, David Hildenbrand wrote:
> On 18.01.22 02:34, Gavin Shan wrote:
> > This enables virtio-mem device support by allowing to enable the
> > corresponding kernel config option (CONFIG_VIRTIO_MEM) on the
> > architecture.
> >
> > Signed-off-by: Gavin Shan <gshan@redhat.com>
> > ---
> > drivers/virtio/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> > index 34f80b7a8a64..bf3f6ebdaa3b 100644
> > --- a/drivers/virtio/Kconfig
> > +++ b/drivers/virtio/Kconfig
> > @@ -106,7 +106,7 @@ config VIRTIO_BALLOON
> > config VIRTIO_MEM
> > tristate "Virtio mem driver"
> > default m
> > - depends on X86_64
> > + depends on X86_64 || ARM64
> > depends on VIRTIO
> > depends on MEMORY_HOTPLUG
> > depends on MEMORY_HOTREMOVE
>
> With MEMBLOCK_DRIVER_MANAGED in place upstream, kexec should be fine.
>
>
> Can you adjust/rephrase the comment as well? Like
>
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index 34f80b7a8a64..88028ca01c8f 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -116,8 +116,9 @@ config VIRTIO_MEM
> This driver provides access to virtio-mem paravirtualized memory
> devices, allowing to hotplug and hotunplug memory.
>
> - This driver was only tested under x86-64, but should theoretically
> - work on all architectures that support memory hotplug and hotremove.
> + This driver was only tested under x86-64 and arm64, but should
> + theoretically work on all architectures that support memory hotplug and
> + hotremove.
>
> If unsure, say M.
>
>
>
> Acked-by: David Hildenbrand <david@redhat.com>
with this:
Acked-by: Michael S. Tsirkin <mst@redhat.com>
I guess I will merge this? It's a small change so - let's go for this
release straight away?
> --
> Thanks,
>
> David / dhildenb
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/virtio: Enable virtio mem for ARM64
2022-01-18 10:43 ` Michael S. Tsirkin
@ 2022-01-18 10:48 ` David Hildenbrand
0 siblings, 0 replies; 6+ messages in thread
From: David Hildenbrand @ 2022-01-18 10:48 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: Jonathan Cameron, shan.gavin, virtualization
On 18.01.22 11:43, Michael S. Tsirkin wrote:
> On Tue, Jan 18, 2022 at 09:38:21AM +0100, David Hildenbrand wrote:
>> On 18.01.22 02:34, Gavin Shan wrote:
>>> This enables virtio-mem device support by allowing to enable the
>>> corresponding kernel config option (CONFIG_VIRTIO_MEM) on the
>>> architecture.
>>>
>>> Signed-off-by: Gavin Shan <gshan@redhat.com>
>>> ---
>>> drivers/virtio/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
>>> index 34f80b7a8a64..bf3f6ebdaa3b 100644
>>> --- a/drivers/virtio/Kconfig
>>> +++ b/drivers/virtio/Kconfig
>>> @@ -106,7 +106,7 @@ config VIRTIO_BALLOON
>>> config VIRTIO_MEM
>>> tristate "Virtio mem driver"
>>> default m
>>> - depends on X86_64
>>> + depends on X86_64 || ARM64
>>> depends on VIRTIO
>>> depends on MEMORY_HOTPLUG
>>> depends on MEMORY_HOTREMOVE
>>
>> With MEMBLOCK_DRIVER_MANAGED in place upstream, kexec should be fine.
>>
>>
>> Can you adjust/rephrase the comment as well? Like
>>
>> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
>> index 34f80b7a8a64..88028ca01c8f 100644
>> --- a/drivers/virtio/Kconfig
>> +++ b/drivers/virtio/Kconfig
>> @@ -116,8 +116,9 @@ config VIRTIO_MEM
>> This driver provides access to virtio-mem paravirtualized memory
>> devices, allowing to hotplug and hotunplug memory.
>>
>> - This driver was only tested under x86-64, but should theoretically
>> - work on all architectures that support memory hotplug and hotremove.
>> + This driver was only tested under x86-64 and arm64, but should
>> + theoretically work on all architectures that support memory hotplug and
>> + hotremove.
>>
>> If unsure, say M.
>>
>>
>>
>> Acked-by: David Hildenbrand <david@redhat.com>
>
> with this:
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>
> I guess I will merge this? It's a small change so - let's go for this
> release straight away?
Yes, no need to wait for the next cycle.
--
Thanks,
David / dhildenb
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-18 10:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-18 1:34 [PATCH] drivers/virtio: Enable virtio mem for ARM64 Gavin Shan
2022-01-18 8:38 ` David Hildenbrand
2022-01-18 8:42 ` Gavin Shan
[not found] ` <20220118092249.0000358c@Huawei.com>
2022-01-18 9:33 ` Gavin Shan
2022-01-18 10:43 ` Michael S. Tsirkin
2022-01-18 10:48 ` David Hildenbrand
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.