From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1 of 6 resend] pkg-download.mk: allow using localfiles outside of package infrastructure
Date: Sun, 15 Jul 2012 13:24:24 +0200 [thread overview]
Message-ID: <5002A868.70107@mind.be> (raw)
In-Reply-To: <1dcdff3e9437fc63cd4b.1340343754@beantl019720>
On 06/22/12 07:42, Thomas De Schampheleire wrote:
> The localfiles download method uses $($(PKG)_SITE))) and
> $($(PKG)_SOURCE) instead of $(1) and $(2). This means that it can only
> be used for package downloads (through gentargets, autotargets, ...)
> and not for other downloads like external toolchains.
>
> This patch changes localfiles to allow this, just as the wget and scp
> download methods already did.
> For the version control download methods, nothing changes.
Is there any reason not to do it for the VCS download methods?
>
> Signed-off-by: Thomas De Schampheleire<thomas.de.schampheleire@gmail.com>
>
> ---
> package/pkg-download.mk | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/package/pkg-download.mk b/package/pkg-download.mk
> --- a/package/pkg-download.mk
> +++ b/package/pkg-download.mk
> @@ -174,16 +174,16 @@ define SHOW_EXTERNAL_DEPS_WGET
> endef
>
> define DOWNLOAD_LOCALFILES
> - test -e $(DL_DIR)/$($(PKG)_SOURCE) || \
> - $(LOCALFILES) $(call qstrip,$(subst file://,,$($(PKG)_SITE)))/$($(PKG)_SOURCE) $(DL_DIR)
> + test -e $(DL_DIR)/$(2) || \
> + $(LOCALFILES) $(call qstrip,$(subst file://,,$(1))) $(DL_DIR)
Shouldn't this be
$(LOCALFILES) $(call qstrip,$(subst file://,,$(1))) $(DL_DIR)/$(2)
> endef
>
> define SOURCE_CHECK_LOCALFILES
> - test -e $(call qstrip,$(subst file://,,$($(PKG)_SITE)))/$($(PKG)_SOURCE)
> + test -e $(call qstrip,$(subst file://,,$(1)))
> endef
>
> define SHOW_EXTERNAL_DEPS_LOCALFILES
> - echo $($(PKG)_SITE)/$($(PKG)_SOURCE)
> + echo $(2)
Funny, the original was actually wrong...
Regards,
Arnout
> endef
>
> ################################################################################
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2012-07-15 11:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 5:42 [Buildroot] [PATCH 0 of 6 resend] Improve support for custom external toolchains (and related changes) Thomas De Schampheleire
2012-06-22 5:42 ` [Buildroot] [PATCH 1 of 6 resend] pkg-download.mk: allow using localfiles outside of package infrastructure Thomas De Schampheleire
2012-07-15 11:24 ` Arnout Vandecappelle [this message]
2012-07-16 3:14 ` Thomas De Schampheleire
2012-07-17 7:34 ` Arnout Vandecappelle
2012-07-22 16:24 ` Thomas Petazzoni
2012-06-22 5:42 ` [Buildroot] [PATCH 2 of 6 resend] pkg-download.mk: use stripurischeme function in localfiles download method Thomas De Schampheleire
2012-07-15 11:25 ` Arnout Vandecappelle
2012-06-22 5:42 ` [Buildroot] [PATCH 3 of 6 resend] pkg-download.mk: support detection of URI schemes in DOWNLOAD Thomas De Schampheleire
2012-07-15 11:28 ` Arnout Vandecappelle
2012-06-22 5:42 ` [Buildroot] [PATCH 4 of 6 resend] toolchain-external/Config.in: fix indentation Thomas De Schampheleire
2012-07-15 11:30 ` Arnout Vandecappelle
2012-06-22 5:42 ` [Buildroot] [PATCH 5 of 6 resend] toolchain-external: allow downloading a custom toolchain Thomas De Schampheleire
2012-07-15 11:44 ` Arnout Vandecappelle
2012-06-22 5:42 ` [Buildroot] [PATCH 6 of 6 resend] toolchain-external: line up comments with reality Thomas De Schampheleire
2012-07-15 11:32 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5002A868.70107@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.