From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Andy Parkins <andyparkins@gmail.com>,
Sitaram Chamarty <sitaramc@gmail.com>
Subject: Re: [RFC] Add a new email notification script to "contrib"
Date: Mon, 16 Jul 2012 00:45:13 +0200 [thread overview]
Message-ID: <500347F9.3040005@alum.mit.edu> (raw)
In-Reply-To: <7v1ukd5wis.fsf@alter.siamese.dyndns.org>
On 07/15/2012 09:11 AM, Junio C Hamano wrote:
> mhagger@alum.mit.edu writes:
>> Add a new Python script, contrib/hooks/post-receive-multimail.py, that
>> can be used to send notification emails describing pushes into a git
>> repository. This script is derived from
>> contrib/hooks/post-receive-mail, but has many differences, including:
>
> The new script (I didn't read it at all) may be useful to some
> people, but I'm fairly negative on adding 47 different "I know there
> is something in contrib/, I looked at it, but I didn't bother
> updating it to fill my needs and wrote a new one instead" at this
> point to my tree.
I understand your concern.
> It is a different matter if the patch was to replace the existing
> one, saying "the users of the old script can use this one, which is
> backward compatible with respect to the external interface such as
> command line, or configuration variables used". Instead of a total
> backward compatibility, "here is a script to migrate the existing
> set of configuration variables so that users of the old script can
> run it once, and start using this new one" is also perfectly fine.
>
> Such an enhancement, especially if the rewritten result is cleaner
> and easier to enhance going forward than the original, would be very
> much appreciated.
I didn't originally put the new script forward as a replacement for the
old one mainly because it seems that Python is relatively unwelcome in
the git project. But if the use of Python doesn't disqualify it, then
yes, I think the new script (with a little more work) will be a worthy
replacement for the old shell script.
The new script is already mostly compatible with the old one:
* It accepts the same command-line arguments and uses most of the same
configuration variables.
* It is possible to configure the new script to send only the refchange
summary emails and skip sending the emails for individual commits,
though I would want to put some work into supporting this mode better.
* I tested the earliest versions of the new script by verifying that its
output was identical to that of the shell script. (Of course the output
is no longer identical; I claim that it is now better :-) .)
So I think it would be quite possible to touch up the new script to make
it a drop-in replacement for the old one, and I am willing to do so. If
I understand correctly that there is a non-negligible chance of this
happening, then I will continue working towards that goal.
Michael
next prev parent reply other threads:[~2012-07-15 22:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-14 6:59 [RFC] Add a new email notification script to "contrib" mhagger
2012-07-14 9:46 ` Stefan Näwe
[not found] ` <CALUzUxoi-X2nTTFF7utJz2DOTDE8-s7QOgR=HmQAkOVkGY17BA@mail.gmail.com>
2012-07-14 12:03 ` Stefan Naewe
2012-07-15 4:38 ` Michael Haggerty
2012-07-15 7:11 ` Junio C Hamano
2012-07-15 22:45 ` Michael Haggerty [this message]
2012-07-16 15:57 ` Marc Branchaud
2012-07-16 16:38 ` Michael Haggerty
2012-07-16 16:16 ` Matthieu Moy
2012-07-16 16:48 ` Michael Haggerty
2012-07-16 17:47 ` Junio C Hamano
2012-07-16 19:05 ` Michael Haggerty
2012-07-16 19:21 ` Junio C Hamano
2012-07-18 7:52 ` Matthieu Moy
2012-07-20 10:01 ` Michael Haggerty
2012-11-07 21:47 ` Ævar Arnfjörð Bjarmason
2012-11-08 9:42 ` Michael Haggerty
2012-11-08 11:39 ` Ævar Arnfjörð Bjarmason
2012-11-08 12:17 ` Michael Haggerty
2012-11-08 15:38 ` Ævar Arnfjörð Bjarmason
2012-11-22 7:32 ` Michael Haggerty
2012-11-08 16:24 ` Marc Branchaud
2012-11-08 16:37 ` Ævar Arnfjörð Bjarmason
2012-11-08 16:46 ` Marc Branchaud
2012-11-08 16:03 ` Marc Branchaud
2012-11-22 7:27 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500347F9.3040005@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sitaramc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.