All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Mitsyanko <i.mitsyanko@samsung.com>
Cc: e.voevodin@samsung.com, qemu-devel@nongnu.org, agraf@suse.de,
	kyungmin.park@samsung.com, kraxel@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test
Date: Tue, 17 Jul 2012 22:03:48 +0400	[thread overview]
Message-ID: <5005A904.5000006@samsung.com> (raw)
In-Reply-To: <1342546459-21993-1-git-send-email-i.mitsyanko@samsung.com>

I see now that this bug was already noticed, please ignore this mail

On 07/17/2012 09:34 PM, Igor Mitsyanko wrote:
> After commit 417c9d72d48275d19c60861896efd4962d21aca2 all configure tests are
> executed with -Werror flag. Current ALSA configure test program invokes a warning:
>
> warning: ‘handle’ is used uninitialized in this function [-Wuninitialized]
>
> which results in error with -Werror flag and, consequently, in alsa test failing.
> This means that QEMU won't configure with "--audio-drv-list=alsa".
>
> Initialize "handle" variable to fix compilation warning.
>
> Signed-off-by: Igor Mitsyanko <i.mitsyanko@samsung.com>
> ---
>   configure |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index 0a3896e..cf4669f 100755
> --- a/configure
> +++ b/configure
> @@ -1888,7 +1888,7 @@ for drv in $audio_drv_list; do
>       case $drv in
>       alsa)
>       audio_drv_probe $drv alsa/asoundlib.h -lasound \
> -        "snd_pcm_t **handle; return snd_pcm_close(*handle);"
> +        "snd_pcm_t *handle = 0; return snd_pcm_close(handle);"
>       libs_softmmu="-lasound $libs_softmmu"
>       ;;
>
>

  reply	other threads:[~2012-07-17 18:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-17 17:34 [Qemu-devel] [PATCH] configure: fix ALSA configure test Igor Mitsyanko
2012-07-17 18:03 ` Igor Mitsyanko [this message]
2012-07-17 18:32   ` Stefan Weil
2012-07-17 18:46     ` Peter Maydell
2012-07-17 19:24       ` Stefan Weil
2012-07-17 19:28         ` Peter Maydell
2012-07-17 19:42           ` Stefan Weil
2012-07-21  9:37           ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2012-07-23 17:40           ` [Qemu-devel] " Blue Swirl
2012-07-23 17:45             ` Peter Maydell
2012-07-23 19:32               ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5005A904.5000006@samsung.com \
    --to=i.mitsyanko@samsung.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=e.voevodin@samsung.com \
    --cc=kraxel@redhat.com \
    --cc=kyungmin.park@samsung.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.