From: Yao Zhao <yao.zhao@windriver.com>
To: Saul Wold <sgw@linux.intel.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2] dbus-glib: fix compile error when enable-tests
Date: Tue, 17 Jul 2012 15:26:55 -0400 [thread overview]
Message-ID: <5005BC7F.4040804@windriver.com> (raw)
In-Reply-To: <5005B87F.8000408@linux.intel.com>
On 12-07-17 03:09 PM, Saul Wold wrote:
> On 07/17/2012 12:04 PM, Yao Zhao wrote:
>> test-service-glib-include-glib-only.patch: fixes the compiling failure
>> that test-service-glib.c includes glib/gquark.h not glib.h directly.
>>
>
> I hope that you will re-submit the unit test packaging also, that will
> be good to have.
>
Yes, I will and I am testing just in case I made mistakes.
>
>> [YOCTO #2762]
>>
>> Signed-off-by: Yao Zhao <yao.zhao@windriver.com>
>> ---
>> .../test-service-glib-include-glib-only.patch | 13
>> +++++++++++++
>> meta/recipes-core/dbus/dbus-glib.inc | 4 +++-
>> 2 files changed, 16 insertions(+), 1 deletion(-)
>> create mode 100644
>> meta/recipes-core/dbus/dbus-glib-0.98/test-service-glib-include-glib-only.patch
>>
>> diff --git
>> a/meta/recipes-core/dbus/dbus-glib-0.98/test-service-glib-include-glib-only.patch
>> b/meta/recipes-core/dbus/dbus-glib-0.98/test-service-glib-include-glib-only.patch
>>
>> new file mode 100644
>> index 0000000..e0bc0c6
>> --- /dev/null
>> +++
>> b/meta/recipes-core/dbus/dbus-glib-0.98/test-service-glib-include-glib-only.patch
>> @@ -0,0 +1,13 @@
>
> This is missing a patch header, Upstream-Status and Signed-off-by:
>
will do!
yao
> Sau!
>
>> +diff --git a/test/core/test-service-glib.c
>> b/test/core/test-service-glib.c
>> +index 3355890..7291f35 100644
>> +--- a/test/core/test-service-glib.c
>> ++++ b/test/core/test-service-glib.c
>> +@@ -11,7 +11,7 @@
>> + #include <string.h>
>> + #include <glib/gi18n.h>
>> + #include <glib-object.h>
>> +-#include <glib/gquark.h>
>> ++#include <glib.h>
>> +
>> + #include "my-object.h"
>> + #include "my-object-subclass.h"
>> diff --git a/meta/recipes-core/dbus/dbus-glib.inc
>> b/meta/recipes-core/dbus/dbus-glib.inc
>> index da2845a..f554ce8 100644
>> --- a/meta/recipes-core/dbus/dbus-glib.inc
>> +++ b/meta/recipes-core/dbus/dbus-glib.inc
>> @@ -11,7 +11,9 @@ DEPENDS = "expat glib-2.0 virtual/libintl
>> dbus-glib-native dbus"
>> DEPENDS_virtclass-native = "glib-2.0-native dbus-native"
>>
>> SRC_URI =
>> "http://dbus.freedesktop.org/releases/dbus-glib/dbus-glib-${PV}.tar.gz \
>> - file://no-examples.patch"
>> + file://no-examples.patch \
>> + file://test-service-glib-include-glib-only.patch \
>> +"
>>
>> inherit autotools pkgconfig gettext
>>
>>
>
prev parent reply other threads:[~2012-07-17 23:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 19:04 [PATCH v2] dbus-glib: fix compile error when enable-tests Yao Zhao
2012-07-17 19:09 ` Saul Wold
2012-07-17 19:26 ` Yao Zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5005BC7F.4040804@windriver.com \
--to=yao.zhao@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.