From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrDoY-0008Sy-Q5 for qemu-devel@nongnu.org; Tue, 17 Jul 2012 15:52:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrDoX-0002KS-JB for qemu-devel@nongnu.org; Tue, 17 Jul 2012 15:52:10 -0400 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:51945) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrDoW-0002K9-Vo for qemu-devel@nongnu.org; Tue, 17 Jul 2012 15:52:09 -0400 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 18 Jul 2012 01:22:05 +0530 Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6HJq22Y59965540 for ; Wed, 18 Jul 2012 01:22:03 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6I1Mbj8027079 for ; Wed, 18 Jul 2012 11:22:37 +1000 Message-ID: <5005C253.1010506@linux.vnet.ibm.com> Date: Wed, 18 Jul 2012 01:21:47 +0530 From: Harsh Bora MIME-Version: 1.0 References: <1341307259-27262-1-git-send-email-harsh@linux.vnet.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 0/3] Simpletrace v2: Support multiple args, strings. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com On 07/17/2012 08:53 PM, Stefan Hajnoczi wrote: > On Tue, Jul 3, 2012 at 10:20 AM, Harsh Prateek Bora > wrote: >> Existing simpletrace backend allows to trace at max 6 args and does not >> support strings. This newer tracelog format gets rid of fixed size records >> and therefore allows to trace variable number of args including strings. >> >> Sample trace: >> v9fs_version 0.000 tag=0xffff id=0x64 msize=0x2000 version=9P2000.L >> v9fs_version_return 6.705 tag=0xffff id=0x64 msize=0x2000 version=9P2000.L >> v9fs_attach 174.467 tag=0x1 id=0x68 fid=0x0 afid=0xffffffffffffffff >> uname=nobody aname= >> v9fs_attach_return 4720.454 tag=0x1 id=0x68 type=0xffffffffffffff80 >> version=0x4f2a4dd0 path=0x220ea6 > > I have successfully tested it with the fix that I posted. Writing > simpletrace.Analyzer Python scripts still works - now with string > arguments too :). > > Besides the last few comments on Patch 2, this looks okay now. Thanks, I have the updated patches ready except for the question asked on prev reply. Shall I fold your fix in patch 2 with comments as necessary. Let me know if I need to add your s-o-b after merging your fix in patch #2? You can update the commit message as you feel appropriate while merging to your tree though. regards, Harsh > > Stefan >