Re: [PATCH 1/4] QMP, Introduce set-global-dirty-log command.

From: Avi Kivity <avi@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Anthony Perard <anthony.perard@citrix.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Xen Devel <xen-devel@lists.xen.org>,
	QEMU-devel <qemu-devel@nongnu.org>,
	Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [PATCH 1/4] QMP, Introduce set-global-dirty-log command.
Date: Wed, 18 Jul 2012 11:30:49 +0300	[thread overview]
Message-ID: <50067439.3050801__32049.7765591883$1342600381$gmane$org@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1207171855360.23783@kaball.uk.xensource.com>

On 07/17/2012 08:58 PM, Stefano Stabellini wrote:
> On Tue, 17 Jul 2012, Avi Kivity wrote:
>> On 07/17/2012 04:30 PM, Anthony PERARD wrote:
>> > This command is used during a migration of a guest under Xen. It calls
>> > memory_global_dirty_log_start or memory_global_dirty_log_stop according to the
>> > argument pass to the command.
>> 
>> Is the command truly needed?  Can't it come from the xen library you
>> link to?
> 
> I thought that a while ago we decided to use QMP rather than xenstore to
> issue Xen commands to QEMU.
> The only xenstore stuff left are the PV protocols and few parameters.
> 
> Of course we could use xenstore to issue commands again, but it goes
> against the last year and an half of development :-)

This particular command is weird.  You enable dirty logging via an
external interface, but all output goes through the internal interface.
 It doesn't make much sense.

But let's not reopen the issue, if it was decided to go with qmp command
for those things then so be it.

-- 
error compiling committee.c: too many arguments to function