From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52313)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SrX7a-0003DS-Bs
	for qemu-devel@nongnu.org; Wed, 18 Jul 2012 12:29:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SrX7Z-0008Qr-5D
	for qemu-devel@nongnu.org; Wed, 18 Jul 2012 12:29:06 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:46529)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SrX7Y-0008Qm-UF
	for qemu-devel@nongnu.org; Wed, 18 Jul 2012 12:29:05 -0400
Message-ID: <5006E44D.6020600@weilnetz.de>
Date: Wed, 18 Jul 2012 18:29:01 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <500657F2.1080703@ozlabs.ru>
	<CAFEAcA-eeEuZaxynPxT15prrFNqFk14QtpZp46Fj4n_fLM3vVQ@mail.gmail.com>
In-Reply-To: <CAFEAcA-eeEuZaxynPxT15prrFNqFk14QtpZp46Fj4n_fLM3vVQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] qemu in full emulation on win32
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org, Hannes Reinecke <hare@suse.de>, Paolo Bonzini <pbonzini@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, Richard Henderson <rth@twiddle.net>

Am 18.07.2012 10:01, schrieb Peter Maydell:
> On 18 July 2012 07:30, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
>> 1. The size of the following is 7 bytes on linux and 8 bytes on Windows:
>> struct {
>>      uint32_t hi;
>>      uint64_t child;
>>      uint64_t parent;
>>      uint64_t size;
>> } __attribute__((packed)) ranges[];
>>
>> The structure is used between QEMU and Open Firmware (powerpc bios) so it is important.
>
> I think this struct should use QEMU_PACKED, which will
> ensure that it is packed to GCC rules rather than MS
> rules.
>
> We also seem to have let a pile of new uses of attribute((packed))
> slip in in hw/mfi.h. Those are probably bugs too.
>
> -- PMM

They are bugs (for w32 / w64 hosts). I just sent a patch to fix them.

Some more which I did not fix are in the TCG debugger interface.
Maybe those also need to be fixed for w32 / w64, but that needs
more tests and reading of the debugger interface documentation.
Maybe Richard Henderson knows whether they should use QEMU_PACKED,
too.

Regards,

Stefan W.