Re: [Powertop] [PATCH] Get rid of ncurses' TRUE and FALSE

[Chris Ferron <chris.e.ferron at linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2159 bytes --]

On 07/18/2012 02:17 AM, Igor Zhbanov wrote:
> Get rid of TRUE and FALSE ncurses' defines used for boolean variables
> initialization. This fix also helps build without ncurses support.
> ---
>   src/main.cpp          |    6 +++---
>   src/tuning/tuning.cpp |    6 +++---
>   2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/src/main.cpp b/src/main.cpp
> index 7a1b976..9f53b46 100644
> --- a/src/main.cpp
> +++ b/src/main.cpp
> @@ -354,7 +354,7 @@ int main(int argc, char **argv)
>   {
>   	int option_index;
>   	int c;
> -	bool wantreport = FALSE;
> +	bool wantreport = false;
>   	char filename[4096];
>   	char workload[4096] = {0,};
>   	int  iterations = 1;
> @@ -396,7 +396,7 @@ int main(int argc, char **argv)
>   				break;
>   
>   			case 'h': /* html report */
> -				wantreport = TRUE;
> +				wantreport = true;
>   				reporttype = 1;
>   				sprintf(filename, "%s", optarg ? optarg : "PowerTOP.html" );
>   				break;
> @@ -417,7 +417,7 @@ int main(int argc, char **argv)
>   				break;
>   				
>   			case 'C': /* csv report*/
> -				wantreport = TRUE;
> +				wantreport = true;
>   				reporttype = 0;
>   				sprintf(filename, "%s", optarg ? optarg : "PowerTOP.csv");
>   				break;
> diff --git a/src/tuning/tuning.cpp b/src/tuning/tuning.cpp
> index 1a90417..865d986 100644
> --- a/src/tuning/tuning.cpp
> +++ b/src/tuning/tuning.cpp
> @@ -43,7 +43,7 @@
>   #include "../lib.h"
>   
>   static void sort_tunables(void);
> -static bool should_clear = FALSE;
> +static bool should_clear = false;
>   
>   #ifndef DISABLE_NCURSES
>   class tuning_window: public tab_window {
> @@ -103,7 +103,7 @@ static void __tuning_update_display(int cursor_pos)
>   		return;
>   
>   	if (should_clear) {
> -		should_clear = FALSE;
> +		should_clear = false;
>   		wclear(win);
>   	}
>   
> @@ -185,7 +185,7 @@ static bool tunables_sort(class tunable * i, class tunable * j)
>   void tuning_window::window_refresh()
>   {
>   	clear_tuning();
> -	should_clear = TRUE;
> +	should_clear = true;
>   	init_tuning();
>   }
>   
Your patch has been merged
Thank You