All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: linux-mtd@lists.infradead.org
Subject: ARM: LPC32XX MLC NAND Bad Block Handling
Date: Thu, 19 Jul 2012 14:49:24 +0200	[thread overview]
Message-ID: <50080254.4020001@embedded-brains.de> (raw)

Hello,

it seems that the LPC32XX MLC NAND driver uses nand_default_block_markbad() to 
mark a block as bad.  This function will use nand_do_write_oob() with 
MTD_OPS_PLACE_OOB to write the bad block marker in the bad block itself.  This 
function will use chip->ecc.write_oob() to write the OOB which is

static int lpc32xx_write_oob(struct mtd_info *mtd, struct nand_chip *chip,
			      int page)
{
	/* None, write_oob conflicts with the automatic LPC MLC ECC decoder! */
	return 0;
}

Does this mean that the bad block mark is only present in the bad block table?

I think the driver should set NAND_BBT_NO_OOB_BBM to make this clear.

-- 
Sebastian Huber, embedded brains GmbH

Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany
Phone   : +49 89 18 90 80 79-6
Fax     : +49 89 18 90 80 79-9
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

                 reply	other threads:[~2012-07-19 12:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50080254.4020001@embedded-brains.de \
    --to=sebastian.huber@embedded-brains.de \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.