From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH 4/4] xen: Always set the vram dirty during
	migration.
Date: Fri, 20 Jul 2012 15:11:27 +0100
Message-ID: <5009670F.1000209__20669.7328402244$1342793615$gmane$org@citrix.com>
References: <1342531805-29894-1-git-send-email-anthony.perard@citrix.com>
	<1342531805-29894-5-git-send-email-anthony.perard@citrix.com>
	<alpine.DEB.2.02.1207171907580.23783@kaball.uk.xensource.com>
	<alpine.DEB.2.02.1207171929150.23783@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1207171929150.23783@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Luiz Capitulino <lcapitulino@redhat.com>, Xen Devel <xen-devel@lists.xen.org>, QEMU-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>
List-Id: xen-devel@lists.xenproject.org

On 17/07/12 19:30, Stefano Stabellini wrote:
> On Tue, 17 Jul 2012, Stefano Stabellini wrote:
>> On Tue, 17 Jul 2012, Anthony PERARD wrote:
>>> Because the call to track the dirty bit in the video ram during migration won't
>>> work (it returns -1), we set dirtybit on the all video ram.
>>>
>>> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
>>> ---
>>>   xen-all.c |    5 +++++
>>>   1 files changed, 5 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/xen-all.c b/xen-all.c
>>> index 498883b..00bdb50 100644
>>> --- a/xen-all.c
>>> +++ b/xen-all.c
>>> @@ -502,6 +502,11 @@ static void xen_sync_dirty_bitmap(XenIOState *state,
>>>           return;
>>>       }
>>>
>>> +    if (unlikely(xen_in_migration)) {
>>> +        /* track_dirty_vram does not work during migration */
>>> +        memory_region_set_dirty(framebuffer, 0, size);
>>> +        return;
>>> +    }
>>>       rc = xc_hvm_track_dirty_vram(xen_xc, xen_domid,
>>>                                    start_addr >> TARGET_PAGE_BITS, npages,
>>>                                    bitmap);
>>
>> Why are you setting the entire framebuffer dirty?
>> We should set dirty only the actualy region that is supposed to be
>> dirty.

I set the dirty bit on the all framebuffer because the track dirty call 
fail, so I don't which bits are dirty. This one is for QEMU to know 
which part of the screen need to be updated.

> Also memory_region_set_dirty calls cpu_physical_memory_set_dirty_range,
> in which you didn't add a call to xen_modified_memory.



-- 
Anthony PERARD