From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46807)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1StJFE-0000Fj-BM
	for qemu-devel@nongnu.org; Mon, 23 Jul 2012 10:04:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1StJFC-0008V3-Ig
	for qemu-devel@nongnu.org; Mon, 23 Jul 2012 10:04:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:5497)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1StJFC-0008Ux-AD
	for qemu-devel@nongnu.org; Mon, 23 Jul 2012 10:04:18 -0400
Message-ID: <500D5A23.205@redhat.com>
Date: Mon, 23 Jul 2012 16:05:23 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1342785709-3152-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<1342785709-3152-2-git-send-email-stefanha@linux.vnet.ibm.com>
	<500D4754.2020301@redhat.com>
	<CAJSP0QUpnp5TSjk9fXj1x02aJAUx_+6GBC7nDddGrV+A0wK27w@mail.gmail.com>
In-Reply-To: <CAJSP0QUpnp5TSjk9fXj1x02aJAUx_+6GBC7nDddGrV+A0wK27w@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 01/16] net: Add a hub net client
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Zhi Yong Wu <wuzhy@cn.ibm.com>, qemu-devel@nongnu.org

On 07/23/12 15:49, Stefan Hajnoczi wrote:
> On Mon, Jul 23, 2012 at 1:45 PM, Laszlo Ersek <lersek@redhat.com> wrote:
>> Two hairs to split:
>>
>> On 07/20/12 14:01, Stefan Hajnoczi wrote:
>>
>>> +static NetHubPort *net_hub_port_new(NetHub *hub, const char *name)
>>> +{
>>> +    VLANClientState *nc;
>>> +    NetHubPort *port;
>>> +    unsigned int id = hub->num_ports++;
>>
>> There are projects that don't like to put logic or externally visible
>> side-effects into initializers. I don't know about qemu.
> 
> I see what you're saying, we also add it to the hub's port list
> further down.  It could be split into _new() and hub_add_port(hub,
> port) but then autogenerating a unique name becomes harder.  Since
> this function is static, the scope is limited and we can assume
> callers understand what is going on here.
> 
> I'd like to leave it this way or do you see a concrete change that
> improves the code?

Oh no, that's not what I meant -- the function is perfectly fine, it's
just that the post-increment of object A shouldn't be in the definition
/ initializer list of object B. (Keeping the increment and the
construcion in one place is actually a good thing IMHO.)

The idea is, rather than

    unsigned int id = hub->num_ports++;

it should say

    unsigned int id;
    /* ... */
    id = hub->num_ports++;

... Hm, yes, I remember it from
<http://www.manpages.info/freebsd/style.9.html>. But again, I'm not sure
how qemu treats this.

Laszlo