From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:32895)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1StPgS-0004tT-SS
	for qemu-devel@nongnu.org; Mon, 23 Jul 2012 16:56:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1StPgR-0002Vw-Th
	for qemu-devel@nongnu.org; Mon, 23 Jul 2012 16:56:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:18752)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1StPgR-0002Vs-Lb
	for qemu-devel@nongnu.org; Mon, 23 Jul 2012 16:56:51 -0400
Message-ID: <500DBAD6.5050802@redhat.com>
Date: Mon, 23 Jul 2012 22:57:58 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1342785709-3152-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<1342785709-3152-9-git-send-email-stefanha@linux.vnet.ibm.com>
In-Reply-To: <1342785709-3152-9-git-send-email-stefanha@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 08/16] net: Remove VLANState
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Zhi Yong Wu <wuzhy@cn.ibm.com>

On 07/20/12 14:01, Stefan Hajnoczi wrote:

> diff --git a/hw/exynos4_boards.c b/hw/exynos4_boards.c
> index e5c2a5f..4bb0a60 100644
> --- a/hw/exynos4_boards.c
> +++ b/hw/exynos4_boards.c
> @@ -81,7 +81,7 @@ static void lan9215_init(uint32_t base, qemu_irq irq)
>      SysBusDevice *s;
>  
>      /* This should be a 9215 but the 9118 is close enough */
> -    if (nd_table[0].vlan) {
> +    if (nd_table[0].used) {
>          qemu_check_nic_model(&nd_table[0], "lan9118");
>          dev = qdev_create(NULL, "lan9118");
>          qdev_set_nic_properties(dev, &nd_table[0]);

Right, relevant commits: 0ae18cee & 7697079b.


> @@ -970,7 +895,7 @@ void qmp_set_link(const char *name, bool up, Error **errp)
>  done:
>  
>      if (!vc) {
> -        error_set(errp, QERR_DEVICE_NOT_FOUND, name);
> +        qerror_report(QERR_DEVICE_NOT_FOUND, name);
>          return;
>      }

Why? The only caller (at this point) seems to be hmp_set_link(), and it
handles the error (with monitor_printf()).

Thanks,
Laszlo