From: Radu Moisan <radu.moisan@intel.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2] kmod: Handle undefined O_CLOEXEC
Date: Tue, 24 Jul 2012 10:37:41 +0300 [thread overview]
Message-ID: <500E50C5.8000403@intel.com> (raw)
In-Reply-To: <lywr1uzguj.fsf@ensc-virt.intern.sigma-chemnitz.de>
As far as kmod package is concerned O_CLOEXEC is used in constructs like
"O_RDONLY|O_CLOEXEC". O_CLOEXEC can be used (is defined) starting with
Linux kernel ≥2.6.23 and glibc ≥2.7 case in which the patch does not
logically changing anything. However, prior Linux kernel ≥2.6.23
O_CLOEXEC is not defined (the case for CentOS 5.8 - kernel 2.6.18) and
using it in code will cause build errors. My patch provides a workaround
for those distributions that do not have O_CLOEXEC define, just to be
able to build stuff. I have not tested on CentOS 5.8 if the applications
are not broken in some way, but that's not in the scope of this patch.
If something does indeed break, then a totally different patch is
required, targeting a backport of kmod for kernel older than 2.6.23.
Radu
On 07/23/2012 05:34 PM, Enrico Scholz wrote:
> Radu Moisan <radu.moisan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> writes:
>
>> Close-on-exec seems to be unsuported on some architectures like CentOS 5.8
>> and thus causing some packages to fail to build successfully.
> Have you verified that making O_CLOEXEC a noop does not break the
> applications?
>
>
> Enrico
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2012-07-24 7:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 14:04 [PATCH v2] kmod: Handle undefined O_CLOEXEC Radu Moisan
2012-07-23 14:34 ` Enrico Scholz
2012-07-24 7:37 ` Radu Moisan [this message]
2012-07-24 13:27 ` Chris Larson
2012-07-24 13:40 ` Burton, Ross
2012-08-15 18:37 ` McClintock Matthew-B29882
2012-08-15 19:10 ` Chris Larson
2012-08-15 19:27 ` McClintock Matthew-B29882
2012-08-15 19:32 ` Burton, Ross
2012-08-29 13:48 ` Radu Moisan
2012-08-29 17:05 ` Saul Wold
2012-08-30 6:42 ` Radu Moisan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500E50C5.8000403@intel.com \
--to=radu.moisan@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.