All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shlomo Pongartz <shlomop@mellanox.com>
To: Kleber Sacilotto de Souza <klebers@linux.vnet.ibm.com>
Cc: Or Gerlitz <or.gerlitz@gmail.com>,
	Or Gerlitz <ogerlitz@mellanox.com>,
	David Miller <davem@davemloft.net>, <netdev@vger.kernel.org>,
	<jackm@dev.mellanox.co.il>, <yevgenyp@mellanox.co.il>,
	<cascardo@linux.vnet.ibm.com>, <brking@linux.vnet.ibm.com>
Subject: Re: [PATCH] mlx4: Add support for EEH error recovery
Date: Tue, 24 Jul 2012 20:09:56 +0300	[thread overview]
Message-ID: <500ED6E4.60909@mellanox.com> (raw)
In-Reply-To: <500E9F2E.4010209@linux.vnet.ibm.com>

On 7/24/2012 4:12 PM, Kleber Sacilotto de Souza wrote:
> On 07/23/2012 06:26 PM, Or Gerlitz wrote:
>
>> Kleber Sacilotto de Souza <klebers@linux.vnet.ibm.com> wrote:
>>>> For powerpc we have an IBM internal user space tool that injects the
>>>> error on the bus with the aid of the system firmware. The kernel used
>>>> was built with the option:
>>>> CONFIG_EEH=y
>>>> and without the AER options. I will run some more tests with the AER
>>>> options activated.
>>> I tested the powerpc error injection with
>>>
>>> CONFIG_EEH=y
>>> CONFIG_PCIEAER=y
>>> CONFIG_PCIEAER_INJECT=m
>>>
>>> and with the aer_inject module loaded and it didn't affect the EEH
>>> recovery, the adapter recovered as expected.
>> I wasn't sure to follow what did you mean by "it didn't affect the EEH
>> recovery", how did you use the aer_inject module, is that through
>> user-space tool which is available for us?
>
> I wanted to say that I was testing before only with the EEH option
> activated, then I activated the AER options on my powerpc system just to
> make sure these options when activate wouldn't affect the EEH recovery.
> I haven't injected and AER error since I don't have a system with
> hardware support for it.
>
>
> Thanks,

Hi

Using a special extender card I've powered down the card.
None of the callbacks were called (I added printks to be sure).
Shouldn't one on the callbacks be called?

Shlomo Pongratz.

  reply	other threads:[~2012-07-24 17:11 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-20 19:55 [PATCH] mlx4: Add support for EEH error recovery Kleber Sacilotto de Souza
2012-07-22 10:29 ` Or Gerlitz
     [not found] ` <500BD558.2060803@mellanox.com>
2012-07-23  0:15   ` David Miller
2012-07-23 13:18     ` Kleber Sacilotto de Souza
2012-07-23 13:45       ` Or Gerlitz
2012-07-23 18:12         ` Kleber Sacilotto de Souza
2012-07-23 20:53           ` Kleber Sacilotto de Souza
2012-07-23 21:26             ` Or Gerlitz
2012-07-23 21:34               ` David Miller
2012-07-23 21:42                 ` Or Gerlitz
2012-07-23 21:44                   ` David Miller
2012-07-23 22:02                     ` Or Gerlitz
2012-07-23 22:21                       ` David Miller
2012-07-24 13:12               ` Kleber Sacilotto de Souza
2012-07-24 17:09                 ` Shlomo Pongartz [this message]
2012-07-24 17:35                   ` Kleber Sacilotto de Souza
2012-07-24 18:08                     ` Thadeu Lima de Souza Cascardo
2012-07-24 18:35                       ` Shlomo Pongratz
2012-07-24 18:39                       ` Shlomo Pongratz
2012-07-24 21:03 ` David Miller
2012-07-24 22:30   ` Or Gerlitz
2012-07-25 14:38     ` Shlomo Pongartz
     [not found]     ` <5010070B.5040405@mellanox.com>
2012-07-25 15:02       ` Kleber Sacilotto de Souza
2012-07-25 22:19       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=500ED6E4.60909@mellanox.com \
    --to=shlomop@mellanox.com \
    --cc=brking@linux.vnet.ibm.com \
    --cc=cascardo@linux.vnet.ibm.com \
    --cc=davem@davemloft.net \
    --cc=jackm@dev.mellanox.co.il \
    --cc=klebers@linux.vnet.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=or.gerlitz@gmail.com \
    --cc=yevgenyp@mellanox.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.