From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] tcm_vhost: Expose ABI version via VHOST_SCSI_GET_ABI_VERSION Date: Wed, 25 Jul 2012 16:10:51 +0300 Message-ID: <500FF05B.8060602@redhat.com> References: <1343093180-5598-1-git-send-email-nab@linux-iscsi.org> <20120724015634.GD4093@kroah.com> <1343162724.1813.111.camel@haakon2.linux-iscsi.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1343162724.1813.111.camel@haakon2.linux-iscsi.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Nicholas A. Bellinger" Cc: Jens Axboe , linux-scsi , kvm-devel , "Michael S. Tsirkin" , Greg Kroah-Hartman , qemu-devel , lf-virt , Anthony Liguori , target-devel , Paolo Bonzini , Zhi Yong Wu , Christoph Hellwig , Stefan Hajnoczi List-Id: linux-scsi@vger.kernel.org On 07/24/2012 11:45 PM, Nicholas A. Bellinger wrote: >> > diff --git a/drivers/vhost/tcm_vhost.h b/drivers/vhost/tcm_vhost.h >> > index e942df9..3d5378f 100644 >> > --- a/drivers/vhost/tcm_vhost.h >> > +++ b/drivers/vhost/tcm_vhost.h >> > @@ -80,7 +80,17 @@ struct tcm_vhost_tport { >> > >> > #include >> > >> > +/* >> > + * Used by QEMU userspace to ensure a consistent vhost-scsi ABI. >> > + * >> > + * ABI Rev 0: All pre 2012 revisions used by prototype out-of-tree code >> > + * ABI Rev 1: 2012 version for v3.6 kernel merge candiate >> > + */ If it's out of tree, why consider it at all? Put a stable ABI in tree and extend it in compatible ways. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su1N9-0001Tb-Vb for qemu-devel@nongnu.org; Wed, 25 Jul 2012 09:11:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Su1My-0004r9-EY for qemu-devel@nongnu.org; Wed, 25 Jul 2012 09:11:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37480) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su1My-0004qv-6C for qemu-devel@nongnu.org; Wed, 25 Jul 2012 09:11:16 -0400 Message-ID: <500FF05B.8060602@redhat.com> Date: Wed, 25 Jul 2012 16:10:51 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1343093180-5598-1-git-send-email-nab@linux-iscsi.org> <20120724015634.GD4093@kroah.com> <1343162724.1813.111.camel@haakon2.linux-iscsi.org> In-Reply-To: <1343162724.1813.111.camel@haakon2.linux-iscsi.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tcm_vhost: Expose ABI version via VHOST_SCSI_GET_ABI_VERSION List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Nicholas A. Bellinger" Cc: Jens Axboe , linux-scsi , kvm-devel , "Michael S. Tsirkin" , Greg Kroah-Hartman , Zhi Yong Wu , qemu-devel , lf-virt , Anthony Liguori , target-devel , Hannes Reinecke , Paolo Bonzini , Zhi Yong Wu , Christoph Hellwig , Stefan Hajnoczi On 07/24/2012 11:45 PM, Nicholas A. Bellinger wrote: >> > diff --git a/drivers/vhost/tcm_vhost.h b/drivers/vhost/tcm_vhost.h >> > index e942df9..3d5378f 100644 >> > --- a/drivers/vhost/tcm_vhost.h >> > +++ b/drivers/vhost/tcm_vhost.h >> > @@ -80,7 +80,17 @@ struct tcm_vhost_tport { >> > >> > #include >> > >> > +/* >> > + * Used by QEMU userspace to ensure a consistent vhost-scsi ABI. >> > + * >> > + * ABI Rev 0: All pre 2012 revisions used by prototype out-of-tree code >> > + * ABI Rev 1: 2012 version for v3.6 kernel merge candiate >> > + */ If it's out of tree, why consider it at all? Put a stable ABI in tree and extend it in compatible ways. -- error compiling committee.c: too many arguments to function