Re: [dpdk-dev] [PATCH v2 1/2] test/hash: use existing lcore API

From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: thomas@monjalon.net, stephen@networkplumber.org,
	Dharmik.Thakkar@arm.com,  stable@dpdk.org,
	Yipeng Wang <yipeng1.wang@intel.com>,
	Sameh Gobriel <sameh.gobriel@intel.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Pablo de Lara <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] test/hash: use existing lcore API
Date: Thu, 23 May 2019 14:48:17 +0200	[thread overview]
Message-ID: <500d2162-c835-dbf6-0db0-347b90090392@redhat.com> (raw)
In-Reply-To: <1558537617-27813-1-git-send-email-david.marchand@redhat.com>


On 5/22/19 5:06 PM, David Marchand wrote:
> Prefer the existing apis rather than direct access the configuration
> structure.
> 
> test_hash_multi_add_lookup() currently starts n readers and N writers
> using rte_eal_remote_launch().
> It then waits for the N writers to complete with a custom
> multi_writer_done[] array to synchronise over.
> Jump on the occasion to use rte_eal_wait_lcore() so that the code is
> more straightforward:
> - we start n readers with rte_eal_remote_launch(),
> - we start N writers with rte_eal_remote_launch(),
> - we wait for N writers to join with rte_eal_wait_lcore(),
> - we wait for n readers to join with rte_eal_wait_lcore(),
> 
> Fixes: c7eb0972e74b ("test/hash: add lock-free r/w concurrency")
> Fixes: 3f9aab961ed3 ("test/hash: check lock-free extendable bucket")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>   app/test/test_hash_readwrite_lf.c | 41 ++++++++++++++++++---------------------
>   1 file changed, 19 insertions(+), 22 deletions(-)
> 


Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>