From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SvMt7-00031e-8m for qemu-devel@nongnu.org; Sun, 29 Jul 2012 02:22:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SvMt6-00054v-3J for qemu-devel@nongnu.org; Sun, 29 Jul 2012 02:22:01 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:47980) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SvMt5-00052v-Fk for qemu-devel@nongnu.org; Sun, 29 Jul 2012 02:22:00 -0400 Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 29 Jul 2012 11:51:52 +0530 Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6T6LptW24051756 for ; Sun, 29 Jul 2012 11:51:51 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6T6LoMJ024613 for ; Sun, 29 Jul 2012 16:21:50 +1000 Received: from skannery.in.ibm.com ([9.79.211.146]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q6T6LoIO024598 for ; Sun, 29 Jul 2012 16:21:50 +1000 Message-ID: <5014D67E.9040709@linux.vnet.ibm.com> Date: Sun, 29 Jul 2012 11:51:50 +0530 From: Supriya Kannery MIME-Version: 1.0 References: <20120615204648.9853.1225.sendpatchset@skannery.in.ibm.com> <20120615204701.9853.3126.sendpatchset@skannery.in.ibm.com> <4FDBA3FD.5000106@redhat.com> <4FFAEE1C.2050607@redhat.com> <20120711110319.4c1dc584@doriath.home> In-Reply-To: <20120711110319.4c1dc584@doriath.home> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [v1 Patch 1/10]Qemu: Enhance "info block" to display host cache setting Reply-To: supriyak@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 07/11/2012 07:33 PM, Luiz Capitulino wrote: > On Mon, 09 Jul 2012 16:43:40 +0200 > Kevin Wolf wrote: > >> Am 15.06.2012 23:07, schrieb Eric Blake: >>> On 06/15/2012 02:47 PM, Supriya Kannery wrote: >>>> Enhance "info block" to display hostcache setting for each >>>> block device. >>>> >>> >>>> ## >>>> { 'type': 'BlockInfo', >>>> 'data': {'device': 'str', 'type': 'str', 'removable': 'bool', >>>> - 'locked': 'bool', '*inserted': 'BlockDeviceInfo', >>>> + 'locked': 'bool','hostcache': 'bool', '*inserted': 'BlockDeviceInfo', >>> >>> space after comma >>> >>> Since 'hostcache' was not present when talking to older qemu, should we >>> mark it optional? >> >> What does "optional" really mean? I always understood that it means that >> whether the field exists or not depends on some runtime condition, not >> on the qemu version. I would specify something like this, that always >> exists in new qemu versions, in the "Since" section. Or maybe a separate >> "Since" specification like in SpiceInfo for mouse-mode. > > Yes, Kevin is right. > Will add a comment " Since: 1.x" -thanks, Supriya