From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] tcm_vhost: Expose ABI version via VHOST_SCSI_GET_ABI_VERSION Date: Sun, 29 Jul 2012 15:50:59 +0300 Message-ID: <501531B3.5060301@redhat.com> References: <1343093180-5598-1-git-send-email-nab@linux-iscsi.org> <20120724015634.GD4093@kroah.com> <1343162724.1813.111.camel@haakon2.linux-iscsi.org> <20120725115552.GB11098@stefanha-thinkpad.localdomain> <1343250890.1813.173.camel@haakon2.linux-iscsi.org> <20120725223559.GA4786@stefanha-thinkpad.localdomain> <1343270061.1813.181.camel@haakon2.linux-iscsi.org> <5011069A.2080203@redhat.com> <1343333727.22538.3.camel@haakon2.linux-iscsi.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1343333727.22538.3.camel@haakon2.linux-iscsi.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Nicholas A. Bellinger" Cc: Jens Axboe , Stefan Hajnoczi , kvm-devel , "Michael S. Tsirkin" , Greg Kroah-Hartman , qemu-devel , lf-virt , Anthony Liguori , target-devel , linux-scsi , Paolo Bonzini , Zhi Yong Wu , Christoph Hellwig List-Id: linux-scsi@vger.kernel.org On 07/26/2012 11:15 PM, Nicholas A. Bellinger wrote: >> > > Example..? If there is a better way to handle ioctl compat I'd > certainly like to hear about it. > r = ioctl(fd, KVM_CHECK_EXTENSION, KVM_CAP_ASSIGN_DEV_IRQ); if (r == -1) ... if (r) // ioctl(fd, KVM_ASSIGN_DEV_IRQ, ...) is available else not available -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SvSxu-00060X-6N for qemu-devel@nongnu.org; Sun, 29 Jul 2012 08:51:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SvSxt-0008MT-5S for qemu-devel@nongnu.org; Sun, 29 Jul 2012 08:51:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7523) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SvSxs-0008MO-U8 for qemu-devel@nongnu.org; Sun, 29 Jul 2012 08:51:21 -0400 Message-ID: <501531B3.5060301@redhat.com> Date: Sun, 29 Jul 2012 15:50:59 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1343093180-5598-1-git-send-email-nab@linux-iscsi.org> <20120724015634.GD4093@kroah.com> <1343162724.1813.111.camel@haakon2.linux-iscsi.org> <20120725115552.GB11098@stefanha-thinkpad.localdomain> <1343250890.1813.173.camel@haakon2.linux-iscsi.org> <20120725223559.GA4786@stefanha-thinkpad.localdomain> <1343270061.1813.181.camel@haakon2.linux-iscsi.org> <5011069A.2080203@redhat.com> <1343333727.22538.3.camel@haakon2.linux-iscsi.org> In-Reply-To: <1343333727.22538.3.camel@haakon2.linux-iscsi.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tcm_vhost: Expose ABI version via VHOST_SCSI_GET_ABI_VERSION List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Nicholas A. Bellinger" Cc: Jens Axboe , Stefan Hajnoczi , kvm-devel , "Michael S. Tsirkin" , Greg Kroah-Hartman , Zhi Yong Wu , qemu-devel , lf-virt , Anthony Liguori , target-devel , Hannes Reinecke , linux-scsi , Paolo Bonzini , Zhi Yong Wu , Christoph Hellwig On 07/26/2012 11:15 PM, Nicholas A. Bellinger wrote: >> > > Example..? If there is a better way to handle ioctl compat I'd > certainly like to hear about it. > r = ioctl(fd, KVM_CHECK_EXTENSION, KVM_CAP_ASSIGN_DEV_IRQ); if (r == -1) ... if (r) // ioctl(fd, KVM_ASSIGN_DEV_IRQ, ...) is available else not available -- error compiling committee.c: too many arguments to function