From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753773Ab2G3GyE (ORCPT ); Mon, 30 Jul 2012 02:54:04 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:47911 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753253Ab2G3GyB (ORCPT ); Mon, 30 Jul 2012 02:54:01 -0400 Message-ID: <50162F70.2050900@linaro.org> Date: Mon, 30 Jul 2012 07:53:36 +0100 From: Lee Jones User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Mark Brown CC: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de, olalilja@yahoo.se, ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, lrg@ti.com Subject: Re: [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP driver for Device Tree References: <1343393162-11938-1-git-send-email-lee.jones@linaro.org> <1343393162-11938-6-git-send-email-lee.jones@linaro.org> <20120729204218.GI4384@opensource.wolfsonmicro.com> In-Reply-To: <20120729204218.GI4384@opensource.wolfsonmicro.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/07/12 21:42, Mark Brown wrote: > On Fri, Jul 27, 2012 at 01:45:49PM +0100, Lee Jones wrote: > >> + if (of_get_property(np, "stericsson,use-pinctrl", NULL)) >> + msp->use_pinctrl = true; >> + else >> + msp->use_pinctrl = false; > > I don't recall seeing any response to my query about this on the first > iteration. Please don't just ignore review comments. It wasn't intentional. I must have missed it before. > This doesn't seem particularly sane... why is this conditional? It's conditional because only MSP1 and MSP3 have pinctrl support. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP driver for Device Tree Date: Mon, 30 Jul 2012 07:53:36 +0100 Message-ID: <50162F70.2050900@linaro.org> References: <1343393162-11938-1-git-send-email-lee.jones@linaro.org> <1343393162-11938-6-git-send-email-lee.jones@linaro.org> <20120729204218.GI4384@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ey0-f179.google.com (mail-ey0-f179.google.com [209.85.215.179]) by alsa0.perex.cz (Postfix) with ESMTP id 491A326525A for ; Mon, 30 Jul 2012 08:53:59 +0200 (CEST) Received: by eaaa13 with SMTP id a13so697975eaa.38 for ; Sun, 29 Jul 2012 23:54:00 -0700 (PDT) In-Reply-To: <20120729204218.GI4384@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, linus.walleij@stericsson.com, arnd@arndb.de, olalilja@yahoo.se, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, lrg@ti.com, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org T24gMjkvMDcvMTIgMjE6NDIsIE1hcmsgQnJvd24gd3JvdGU6Cj4gT24gRnJpLCBKdWwgMjcsIDIw MTIgYXQgMDE6NDU6NDlQTSArMDEwMCwgTGVlIEpvbmVzIHdyb3RlOgo+Cj4+ICsJaWYgKG9mX2dl dF9wcm9wZXJ0eShucCwgInN0ZXJpY3Nzb24sdXNlLXBpbmN0cmwiLCBOVUxMKSkKPj4gKwkJbXNw LT51c2VfcGluY3RybCA9IHRydWU7Cj4+ICsJZWxzZQo+PiArCQltc3AtPnVzZV9waW5jdHJsID0g ZmFsc2U7Cj4KPiBJIGRvbid0IHJlY2FsbCBzZWVpbmcgYW55IHJlc3BvbnNlIHRvIG15IHF1ZXJ5 IGFib3V0IHRoaXMgb24gdGhlIGZpcnN0Cj4gaXRlcmF0aW9uLiAgUGxlYXNlIGRvbid0IGp1c3Qg aWdub3JlIHJldmlldyBjb21tZW50cy4KCkl0IHdhc24ndCBpbnRlbnRpb25hbC4gSSBtdXN0IGhh dmUgbWlzc2VkIGl0IGJlZm9yZS4KCj4gVGhpcyBkb2Vzbid0IHNlZW0gcGFydGljdWxhcmx5IHNh bmUuLi4gIHdoeSBpcyB0aGlzIGNvbmRpdGlvbmFsPwoKSXQncyBjb25kaXRpb25hbCBiZWNhdXNl IG9ubHkgTVNQMSBhbmQgTVNQMyBoYXZlIHBpbmN0cmwgc3VwcG9ydC4KCi0tIApMZWUgSm9uZXMK TGluYXJvIFNULUVyaWNzc29uIExhbmRpbmcgVGVhbSBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4g c291cmNlIHNvZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3 aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkFsc2EtZGV2ZWwgbWFpbGluZyBsaXN0CkFsc2EtZGV2ZWxAYWxzYS1wcm9qZWN0Lm9yZwpo dHRwOi8vbWFpbG1hbi5hbHNhLXByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vYWxzYS1kZXZl bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Mon, 30 Jul 2012 07:53:36 +0100 Subject: [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP driver for Device Tree In-Reply-To: <20120729204218.GI4384@opensource.wolfsonmicro.com> References: <1343393162-11938-1-git-send-email-lee.jones@linaro.org> <1343393162-11938-6-git-send-email-lee.jones@linaro.org> <20120729204218.GI4384@opensource.wolfsonmicro.com> Message-ID: <50162F70.2050900@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 29/07/12 21:42, Mark Brown wrote: > On Fri, Jul 27, 2012 at 01:45:49PM +0100, Lee Jones wrote: > >> + if (of_get_property(np, "stericsson,use-pinctrl", NULL)) >> + msp->use_pinctrl = true; >> + else >> + msp->use_pinctrl = false; > > I don't recall seeing any response to my query about this on the first > iteration. Please don't just ignore review comments. It wasn't intentional. I must have missed it before. > This doesn't seem particularly sane... why is this conditional? It's conditional because only MSP1 and MSP3 have pinctrl support. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog