From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwZTK-0004ED-Np for qemu-devel@nongnu.org; Wed, 01 Aug 2012 10:00:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwZTI-0003Zf-GJ for qemu-devel@nongnu.org; Wed, 01 Aug 2012 10:00:22 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56513 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwZTI-0003YI-6a for qemu-devel@nongnu.org; Wed, 01 Aug 2012 10:00:20 -0400 Message-ID: <5019366B.1050605@suse.de> Date: Wed, 01 Aug 2012 16:00:11 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1343049748-11539-1-git-send-email-imammedo@redhat.com> <1343049748-11539-2-git-send-email-imammedo@redhat.com> In-Reply-To: <1343049748-11539-2-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] target-i386: move cpu halted decision into x86_cpu_reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , Jan Kiszka Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, ehabkost@redhat.com, gleb@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com Am 23.07.2012 15:22, schrieb Igor Mammedov: > MP initialization protocol differs between cpu families, and for P6 and > onward models it is up to CPU to decide if it will be BSP using this > protocol, so try to model this. However there is no point in implementi= ng > MP initialization protocol in qemu. Thus first CPU is always marked as = BSP. >=20 > This patch: > - moves decision to designate BSP from board into cpu, making cpu > self-sufficient in this regard. Later it will allow to cleanup hw/pc.c > and remove cpu_reset and wrappers from there. > - stores flag that CPU is BSP in IA32_APIC_BASE to model behavior > described in Inted SDM vol 3a part 1 chapter 8.4.1 > - uses MSR_IA32_APICBASE_BSP flag in apic_base for checking if cpu is = BSP >=20 > patch is based on Jan Kiszka's proposal: > http://thread.gmane.org/gmane.comp.emulators.qemu/100806 >=20 > Signed-off-by: Igor Mammedov >=20 > --- > Changelog: > v2: > - fix build for i386-linux-user > spotted-by: Peter Maydell > v3: > - style change requested by Andreas F=C3=A4rber >=20 > v4: > - reuse cpu_is_bsp() rather than open code check if apicbase has BSP= bit set > requested by Gleb Natapov > - hijacked patch [1] to use X86CPU instead of CPUX86State in cpu_is_= bsp() >=20 > v5: > - move Changelog under --- > requested by: Peter Maydell >=20 > 1) [PATCH qom-next 06/59] pc: Pass X86CPU to cpu_is_bsp() > SoB: Andreas F=C3=A4rber > http://lists.gnu.org/archive/html/qemu-devel/2012-05/msg03185.html Reviewed-by: Andreas F=C3=A4rber I'm fine with this patch, including the squashing of my trivial patch without SoB, but would appreciate someone who knows the APIC (Jan?) to add an explicit Acked-by. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg