From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cH8JL-0002WW-Cx for qemu-devel@nongnu.org; Wed, 14 Dec 2016 07:05:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cH8JF-0006XZ-7k for qemu-devel@nongnu.org; Wed, 14 Dec 2016 07:05:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52592) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cH8JE-0006XJ-Vo for qemu-devel@nongnu.org; Wed, 14 Dec 2016 07:05:21 -0500 References: <1481706465-5636-1-git-send-email-thuth@redhat.com> <87lgviiwn0.fsf@dusky.pond.sub.org> From: Thomas Huth Message-ID: <50196ce3-9320-da14-07d2-867e09ffdcfc@redhat.com> Date: Wed, 14 Dec 2016 13:05:11 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.9 v2] Move target-* CPU file into a target/ folder List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Markus Armbruster Cc: QEMU Developers , Paolo Bonzini , Peter Crosthwaite , Richard Henderson , Aurelien Jarno , Cornelia Huck , James Hogan , Jia Liu , Christian Borntraeger , Bastian Koppelmann , Anthony Green , Marcelo Tosatti , Mark Cave-Ayland , Laurent Vivier , Eduardo Habkost , Alexander Graf , Max Filippov , Michael Walle , Yongbok Kim , "Edgar E. Iglesias" , Guan Xuetao , Artyom Tarasenko , David Gibson On 14.12.2016 12:33, Peter Maydell wrote: > On 14 December 2016 at 11:21, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> We've currently got 18 architectures in QEMU, and thus 18 target-xxx >>> folders in the root folder of the QEMU source tree. More architectures >>> (e.g. RISC-V, AVR) are likely to be included soon, too, so the main >>> folder of the QEMU sources slowly gets quite overcrowded with the >>> target-xxx folders. >>> To disburden the main folder a little bit, let's move the target-xxx >>> folders into a dedicated target/ folder, so that target-xxx/ simply >>> becomes target/xxx/ instead. >> >> The root directory is crowded, but hardly because of its 18 target-* >> entries: >> >> $ git-ls-tree --name-only v2.8.0-rc3 | wc -l >> 167 >> >> Getting the 18 target-* out of the way would help a little, but I hate >> making the directory tree deeper. We already got folders in folders in a lot of places, so this is not increasing the maximum depths ;-) >> We have 110 files in the root directory. Moving some of them to >> subdirectories looks more promising to me. > > True, but Thomas has done the work here already, so I don't think > we lose anything by merging it rather than throwing it away. Yes, and please consider that there are more targets coming soon ... RISC-V, AVR, ... and I am pretty sure that we won't stop there. With regards to the other *.c files in the main directory, I agree with Markus, we should move some of them to suitable subdirectories, too. I could have a look at that when I've got some spare minutes... Thomas