From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754247Ab2HBMph (ORCPT ); Thu, 2 Aug 2012 08:45:37 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:41284 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753720Ab2HBMpg (ORCPT ); Thu, 2 Aug 2012 08:45:36 -0400 Message-ID: <501A766C.1060502@linaro.org> Date: Thu, 02 Aug 2012 13:45:32 +0100 From: Lee Jones User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Mark Brown CC: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, olalilja@yahoo.se, ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, lrg@ti.com, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de Subject: Re: [PATCH 18/19] Documentation: Define the MSP Driver Device Tree bindings References: <1343741953-17828-1-git-send-email-lee.jones@linaro.org> <1343741953-17828-19-git-send-email-lee.jones@linaro.org> <20120731135539.GO4468@opensource.wolfsonmicro.com> <5017F2E2.4040100@linaro.org> <20120731151024.GA4468@opensource.wolfsonmicro.com> In-Reply-To: <20120731151024.GA4468@opensource.wolfsonmicro.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/07/12 16:10, Mark Brown wrote: > On Tue, Jul 31, 2012 at 03:59:46PM +0100, Lee Jones wrote: >> On 31/07/12 14:55, Mark Brown wrote: > >>>> +Optional properties: >>>> + - interrupts : The interrupt outputs from the device. > >>> If there's more than one interrupt then how are they ordered? > >> It doesn't matter. If there are any more than one (which there >> aren't in this case), we usually use the interrupt-names property >> then request them by name in the driver. > > So the binding therefore needs to say "The interrupt output from the > device" as there's only one output supported. If we were using > interrupt-names then we'd need to document what the supported names are. Okay, I've changed 'outputs' to 'output'. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 18/19] Documentation: Define the MSP Driver Device Tree bindings Date: Thu, 02 Aug 2012 13:45:32 +0100 Message-ID: <501A766C.1060502@linaro.org> References: <1343741953-17828-1-git-send-email-lee.jones@linaro.org> <1343741953-17828-19-git-send-email-lee.jones@linaro.org> <20120731135539.GO4468@opensource.wolfsonmicro.com> <5017F2E2.4040100@linaro.org> <20120731151024.GA4468@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51]) by alsa0.perex.cz (Postfix) with ESMTP id 01AC3265202 for ; Thu, 2 Aug 2012 14:45:32 +0200 (CEST) Received: by eeke50 with SMTP id e50so1891538eek.38 for ; Thu, 02 Aug 2012 05:45:35 -0700 (PDT) In-Reply-To: <20120731151024.GA4468@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, linus.walleij@stericsson.com, arnd@arndb.de, linux-kernel@vger.kernel.org, olalilja@yahoo.se, STEricsson_nomadik_linux@list.st.com, lrg@ti.com, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org T24gMzEvMDcvMTIgMTY6MTAsIE1hcmsgQnJvd24gd3JvdGU6Cj4gT24gVHVlLCBKdWwgMzEsIDIw MTIgYXQgMDM6NTk6NDZQTSArMDEwMCwgTGVlIEpvbmVzIHdyb3RlOgo+PiBPbiAzMS8wNy8xMiAx NDo1NSwgTWFyayBCcm93biB3cm90ZToKPgo+Pj4+ICtPcHRpb25hbCBwcm9wZXJ0aWVzOgo+Pj4+ ICsgLSBpbnRlcnJ1cHRzICAgICAgIDogVGhlIGludGVycnVwdCBvdXRwdXRzIGZyb20gdGhlIGRl dmljZS4KPgo+Pj4gSWYgdGhlcmUncyBtb3JlIHRoYW4gb25lIGludGVycnVwdCB0aGVuIGhvdyBh cmUgdGhleSBvcmRlcmVkPwo+Cj4+IEl0IGRvZXNuJ3QgbWF0dGVyLiBJZiB0aGVyZSBhcmUgYW55 IG1vcmUgdGhhbiBvbmUgKHdoaWNoIHRoZXJlCj4+IGFyZW4ndCBpbiB0aGlzIGNhc2UpLCB3ZSB1 c3VhbGx5IHVzZSB0aGUgaW50ZXJydXB0LW5hbWVzIHByb3BlcnR5Cj4+IHRoZW4gcmVxdWVzdCB0 aGVtIGJ5IG5hbWUgaW4gdGhlIGRyaXZlci4KPgo+IFNvIHRoZSBiaW5kaW5nIHRoZXJlZm9yZSBu ZWVkcyB0byBzYXkgIlRoZSBpbnRlcnJ1cHQgb3V0cHV0IGZyb20gdGhlCj4gZGV2aWNlIiBhcyB0 aGVyZSdzIG9ubHkgb25lIG91dHB1dCBzdXBwb3J0ZWQuICBJZiB3ZSB3ZXJlIHVzaW5nCj4gaW50 ZXJydXB0LW5hbWVzIHRoZW4gd2UnZCBuZWVkIHRvIGRvY3VtZW50IHdoYXQgdGhlIHN1cHBvcnRl ZCBuYW1lcyBhcmUuCgpPa2F5LCBJJ3ZlIGNoYW5nZWQgJ291dHB1dHMnIHRvICdvdXRwdXQnLgoK LS0gCkxlZSBKb25lcwpMaW5hcm8gU1QtRXJpY3Nzb24gTGFuZGluZyBUZWFtIExlYWQKTGluYXJv Lm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCkZvbGxvdyBMaW5hcm86 IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KQWxzYS1kZXZlbCBtYWlsaW5nIGxpc3QKQWxzYS1kZXZlbEBhbHNh LXByb2plY3Qub3JnCmh0dHA6Ly9tYWlsbWFuLmFsc2EtcHJvamVjdC5vcmcvbWFpbG1hbi9saXN0 aW5mby9hbHNhLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Thu, 02 Aug 2012 13:45:32 +0100 Subject: [PATCH 18/19] Documentation: Define the MSP Driver Device Tree bindings In-Reply-To: <20120731151024.GA4468@opensource.wolfsonmicro.com> References: <1343741953-17828-1-git-send-email-lee.jones@linaro.org> <1343741953-17828-19-git-send-email-lee.jones@linaro.org> <20120731135539.GO4468@opensource.wolfsonmicro.com> <5017F2E2.4040100@linaro.org> <20120731151024.GA4468@opensource.wolfsonmicro.com> Message-ID: <501A766C.1060502@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 31/07/12 16:10, Mark Brown wrote: > On Tue, Jul 31, 2012 at 03:59:46PM +0100, Lee Jones wrote: >> On 31/07/12 14:55, Mark Brown wrote: > >>>> +Optional properties: >>>> + - interrupts : The interrupt outputs from the device. > >>> If there's more than one interrupt then how are they ordered? > >> It doesn't matter. If there are any more than one (which there >> aren't in this case), we usually use the interrupt-names property >> then request them by name in the driver. > > So the binding therefore needs to say "The interrupt output from the > device" as there's only one output supported. If we were using > interrupt-names then we'd need to document what the supported names are. Okay, I've changed 'outputs' to 'output'. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog