From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SykeO-0006kU-1A for qemu-devel@nongnu.org; Tue, 07 Aug 2012 10:20:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SykeF-0003zZ-KI for qemu-devel@nongnu.org; Tue, 07 Aug 2012 10:20:47 -0400 Message-ID: <50212422.4040407@redhat.com> Date: Tue, 07 Aug 2012 08:20:18 -0600 From: Eric Blake MIME-Version: 1.0 References: <1344307320-25094-2-git-send-email-zhlcindy@linux.vnet.ibm.com> <1344341985-10065-1-git-send-email-borntraeger@de.ibm.com> In-Reply-To: <1344341985-10065-1-git-send-email-borntraeger@de.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigE92BE110AA48C7966BECCD26" Subject: Re: [Qemu-devel] [RFC] usb and s390 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: aliguori@us.ibm.com, agraf@suse.de, Li Zhang , qemu-devel@nongnu.org, Jens Freimann , Li Zhang , Eugene Dvurechenski , qemu-ppc@nongnu.org, afaerber@suse.de, david@gibson.dropbear.id.au This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE92BE110AA48C7966BECCD26 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/07/2012 06:19 AM, Christian Borntraeger wrote: > 2nd attempt, with mailing lists on cc.... > This patch reminded us of another thing that we have been working on. > Here is a patch that sits in my patch queue and disables usb for s390 > We have not pushed that patch yet, since several libvirt versions will = always=20 > specify -usb, which will then break.=20 You are correct that older libvirt always specified -usb; but with the upcoming libvirt 0.10.0, we have fixed things to now allow the user to request starting without -usb. >=20 > So are there any opinions about handling the usb option for platforms t= hat > actually dont support it? Libvirt should probably learn which platforms don't support it and automatically omit the -usb without user intervention on those platforms, but at least we have the fallback to explicitly avoid the -usb now. Knowing which platforms support usb might be easier if there were some QMP query-* command that could be used to learn whether a particular machine type supports it. That is, since this series is adding the new syntax '-machine type=3Dpseries,usb=3Doff', libvirt should= be able to query '-machine type=3Dpseries,?' to see what options the given machine has, and preferably through a QMP interface rather than through the command line. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigE92BE110AA48C7966BECCD26 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQISQjAAoJEKeha0olJ0NquOUH/i3AqK6tWYPN5cYPuy/j+/Gp SozSAXlxHEneT6MyAvdkeCKvA2vxbIB20YOis7n+jtoEtJEOR71Tb/hSN6k7pZqf cK2ejM4lNxcr+FV8UieeGeFN5t4qgyNOSV/7ELnYKKnSIxULtvjv1vT6mEeMjM19 PBKbzHHqkkDP0J2PDF2A0BoD9BQ49hOpYxyxujsPls13+tWZk8FuSIqltxFwxHx7 248NHH6rIrpV6Vc9oKjkT79dI0LLOtdV4VnJHB07ILkTw5zvVMh5OBZ9qaBF/AvX v+HIb/CPYidBos7mpUeKuLtOqkGamD//+slbybCjavIqH72bgzntR6dZHdUeolY= =VFZA -----END PGP SIGNATURE----- --------------enigE92BE110AA48C7966BECCD26--