From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH 3/3] KVM: PPC: booke: Added debug handler Date: Tue, 7 Aug 2012 15:44:30 -0500 Message-ID: <50217E2E.6060607@freescale.com> References: <1343977723-25341-1-git-send-email-Bharat.Bhushan@freescale.com> <1343977723-25341-3-git-send-email-Bharat.Bhushan@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Bharat Bhushan , , , Bharat Bhushan To: Alexander Graf Return-path: Received: from ch1ehsobe003.messaging.microsoft.com ([216.32.181.183]:4416 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753667Ab2HGUoy (ORCPT ); Tue, 7 Aug 2012 16:44:54 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 08/07/2012 05:47 AM, Alexander Graf wrote: >> diff --git a/arch/powerpc/kvm/booke_interrupts.S b/arch/powerpc/kvm/booke_interrupts.S >> index 3539805..890673c 100644 >> --- a/arch/powerpc/kvm/booke_interrupts.S >> +++ b/arch/powerpc/kvm/booke_interrupts.S >> @@ -73,6 +73,51 @@ _GLOBAL(kvmppc_handler_\ivor_nr) >> bctr >> .endm >> >> +.macro KVM_DBG_HANDLER ivor_nr scratch srr0 > > This is a lot of asm code. Any chance to share a good share of it with the generic handler? That entire file could use an update to lok more like bookehv_interrupts.S and its use of asm macros. -Scott From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Tue, 07 Aug 2012 20:44:30 +0000 Subject: Re: [PATCH 3/3] KVM: PPC: booke: Added debug handler Message-Id: <50217E2E.6060607@freescale.com> List-Id: References: <1343977723-25341-1-git-send-email-Bharat.Bhushan@freescale.com> <1343977723-25341-3-git-send-email-Bharat.Bhushan@freescale.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf Cc: Bharat Bhushan , kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, Bharat Bhushan On 08/07/2012 05:47 AM, Alexander Graf wrote: >> diff --git a/arch/powerpc/kvm/booke_interrupts.S b/arch/powerpc/kvm/booke_interrupts.S >> index 3539805..890673c 100644 >> --- a/arch/powerpc/kvm/booke_interrupts.S >> +++ b/arch/powerpc/kvm/booke_interrupts.S >> @@ -73,6 +73,51 @@ _GLOBAL(kvmppc_handler_\ivor_nr) >> bctr >> .endm >> >> +.macro KVM_DBG_HANDLER ivor_nr scratch srr0 > > This is a lot of asm code. Any chance to share a good share of it with the generic handler? That entire file could use an update to lok more like bookehv_interrupts.S and its use of asm macros. -Scott