From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF4F5C282DD for ; Mon, 10 Jun 2019 10:10:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 854C52085A for ; Mon, 10 Jun 2019 10:10:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="ZUu4FyQ4"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="SaLCPnR1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388848AbfFJKKE (ORCPT ); Mon, 10 Jun 2019 06:10:04 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46480 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388647AbfFJKKE (ORCPT ); Mon, 10 Jun 2019 06:10:04 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 03D88602F3; Mon, 10 Jun 2019 10:10:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560161403; bh=oMzk0exJ+xInm/wmcPKtXW9VAu75APw0ZR5LIiqwBMA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=ZUu4FyQ4F3QEJLmauV8ESFFe6E8Wsayf9AmyCygmDWmL4yGaNIFiSk/K84j/JFl99 QuWVJf67fyJ/eJGBAXy/l3NDfCne5VePno+QCvl4fjHBHVId8nUfuIe72UFZespvT8 BqFVgkO74GArdKHGYQt3myV9/pAROEAoYExzHRkU= Received: from [10.201.2.161] (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sricharan@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id D6A0E60265; Mon, 10 Jun 2019 10:09:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560161402; bh=oMzk0exJ+xInm/wmcPKtXW9VAu75APw0ZR5LIiqwBMA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=SaLCPnR1Et/BEyNk+ZcTTxeIwo8gyJ/n2d+q5Xul05WI4YqSh0wyjjYUlXeZt+8+Z +O2BI26+KyHgNgyePciF/SQ4O9PzcgvrTyBtFsV+9RRbmDVIbSqwDUzeLy3D/3kh8l P7GuAlKBKloZtGxGR4J58CeiejGr35K20apQDEdE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D6A0E60265 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sricharan@codeaurora.org Subject: Re: [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support To: Christian Lamparter Cc: Rob Herring , Stephen Boyd , Linus Walleij , agross@kernel.org, devicetree , linux-kernel , linux-clk@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-arm Mailing List , =?UTF-8?B?0J/QsNCy0LXQuw==?= References: <1559754961-26783-1-git-send-email-sricharan@codeaurora.org> <1559754961-26783-6-git-send-email-sricharan@codeaurora.org> From: Sricharan R Message-ID: <50231fba-7212-f8b9-9313-0c79294d4cc6@codeaurora.org> Date: Mon, 10 Jun 2019 15:39:56 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Christian, On 6/6/2019 2:11 AM, Christian Lamparter wrote: > On Wed, Jun 5, 2019 at 7:16 PM Sricharan R wrote: >> >> Add initial device tree support for the Qualcomm IPQ6018 SoC and >> CP01 evaluation board. >> >> Signed-off-by: Sricharan R >> Signed-off-by: Abhishek Sahu >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi >> >> + clocks { >> + sleep_clk: sleep_clk { >> + compatible = "fixed-clock"; >> + clock-frequency = <32000>; >> + #clock-cells = <0>; >> + }; >> + > Recently-ish, we ran into an issue with the clock-frequency of the sleep_clk > on older IPQ40XX (and IPQ806x) on the OpenWrt Github and ML. > From what I know, the external "32KHz" crystals have 32768 Hz, but the QSDK > declares them at 32000 Hz. Since you probably have access to the BOM and > datasheets. Can you please confirm what's the real clock frequency for > the IPQ6018. > (And maybe also for the sleep_clk of the IPQ4018 as well?). > What exactly is the issue that you faced ? Looking in to the docs, it is <32000> only on ipq6018 and ipq40xx as well. Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8968FC282DD for ; Mon, 10 Jun 2019 10:10:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E9E22085A for ; Mon, 10 Jun 2019 10:10:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="imwQACkY"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="SaLCPnR1"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="SaLCPnR1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E9E22085A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Om216Hhkd6mAmwfaO/iYZbXia22uplrID7ABOjcS1Ng=; b=imwQACkYkj7Ydc ih4Cy7KYlnOm7H0t3nZ1KehiZN+qyKBXEblHSHI+zua8N09QTGFfAt5sTXRvkvDQu89f/ZE8S3UmI Knru37mosPmbpj2oHGke2l6DhER2q5/jqgMo6xuhNOsF4QL3OyY2NVtt/7vPWcy8movp4GBKumsEo ByGAoeF91DcqzSidbZiN9vVcdAR+DXU1rE3Z6DGSjs39+TpnnG1IPNf7cgVMkvy8hDVDYKzdgczPM vTHPJLIWbq6dZhF1Gz6RWjdxGWI09P5tEcxuvoHi+erVxd6FIxEiEzBjaXceVQyTfZg2gruGu/4QD ePLV7xIIgFmz/fcJ19nQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1haHFe-0005ZA-Tx; Mon, 10 Jun 2019 10:10:06 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1haHFb-00057a-IP for linux-arm-kernel@lists.infradead.org; Mon, 10 Jun 2019 10:10:04 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id EA55360265; Mon, 10 Jun 2019 10:10:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560161402; bh=oMzk0exJ+xInm/wmcPKtXW9VAu75APw0ZR5LIiqwBMA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=SaLCPnR1Et/BEyNk+ZcTTxeIwo8gyJ/n2d+q5Xul05WI4YqSh0wyjjYUlXeZt+8+Z +O2BI26+KyHgNgyePciF/SQ4O9PzcgvrTyBtFsV+9RRbmDVIbSqwDUzeLy3D/3kh8l P7GuAlKBKloZtGxGR4J58CeiejGr35K20apQDEdE= Received: from [10.201.2.161] (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sricharan@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id D6A0E60265; Mon, 10 Jun 2019 10:09:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560161402; bh=oMzk0exJ+xInm/wmcPKtXW9VAu75APw0ZR5LIiqwBMA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=SaLCPnR1Et/BEyNk+ZcTTxeIwo8gyJ/n2d+q5Xul05WI4YqSh0wyjjYUlXeZt+8+Z +O2BI26+KyHgNgyePciF/SQ4O9PzcgvrTyBtFsV+9RRbmDVIbSqwDUzeLy3D/3kh8l P7GuAlKBKloZtGxGR4J58CeiejGr35K20apQDEdE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D6A0E60265 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sricharan@codeaurora.org Subject: Re: [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support To: Christian Lamparter References: <1559754961-26783-1-git-send-email-sricharan@codeaurora.org> <1559754961-26783-6-git-send-email-sricharan@codeaurora.org> From: Sricharan R Message-ID: <50231fba-7212-f8b9-9313-0c79294d4cc6@codeaurora.org> Date: Mon, 10 Jun 2019 15:39:56 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190610_031003_655233_6CE58BB5 X-CRM114-Status: GOOD ( 16.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Stephen Boyd , linux-arm-msm@vger.kernel.org, Linus Walleij , agross@kernel.org, linux-kernel , =?UTF-8?B?0J/QsNCy0LXQuw==?= , "open list:GPIO SUBSYSTEM" , Rob Herring , linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Christian, On 6/6/2019 2:11 AM, Christian Lamparter wrote: > On Wed, Jun 5, 2019 at 7:16 PM Sricharan R wrote: >> >> Add initial device tree support for the Qualcomm IPQ6018 SoC and >> CP01 evaluation board. >> >> Signed-off-by: Sricharan R >> Signed-off-by: Abhishek Sahu >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi >> >> + clocks { >> + sleep_clk: sleep_clk { >> + compatible = "fixed-clock"; >> + clock-frequency = <32000>; >> + #clock-cells = <0>; >> + }; >> + > Recently-ish, we ran into an issue with the clock-frequency of the sleep_clk > on older IPQ40XX (and IPQ806x) on the OpenWrt Github and ML. > From what I know, the external "32KHz" crystals have 32768 Hz, but the QSDK > declares them at 32000 Hz. Since you probably have access to the BOM and > datasheets. Can you please confirm what's the real clock frequency for > the IPQ6018. > (And maybe also for the sleep_clk of the IPQ4018 as well?). > What exactly is the issue that you faced ? Looking in to the docs, it is <32000> only on ipq6018 and ipq40xx as well. Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel