From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932378Ab2HIL7M (ORCPT ); Thu, 9 Aug 2012 07:59:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61655 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932306Ab2HIL7K (ORCPT ); Thu, 9 Aug 2012 07:59:10 -0400 Message-ID: <5023A645.40308@redhat.com> Date: Thu, 09 Aug 2012 14:00:05 +0200 From: Hans de Goede User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: David Rientjes , Linus Torvalds , Andrew Morton , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [GIT PULL for 3.6-rc1] media updates part 2 References: <5017F674.80404@redhat.com> <5023A11C.50502@redhat.com> In-Reply-To: <5023A11C.50502@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, My bad, sorry about this. Mauro's patch looks good. An alternative fix would be to #ifdefify the led code in the drivers themselves. Regards, Hans On 08/09/2012 01:38 PM, Mauro Carvalho Chehab wrote: > Em 08-08-2012 19:28, David Rientjes escreveu: >> On Tue, 31 Jul 2012, Mauro Carvalho Chehab wrote: >> >>> [media] radio-shark: New driver for the Griffin radioSHARK USB radio receiver >> >> This one gives me a build warning if CONFIG_LEDS_CLASS is disabled: >> >> ERROR: "led_classdev_register" [drivers/media/radio/shark2.ko] undefined! >> ERROR: "led_classdev_unregister" [drivers/media/radio/shark2.ko] undefined! >> > > Could you please test the enclosed patch? > > Thanks! > Mauro > > - > > [media] radio-shark: make sure LEDS_CLASS is selected > > As reported by David: > > ERROR: "led_classdev_register" [drivers/media/radio/shark2.ko] undefined! > > ERROR: "led_classdev_unregister" [drivers/media/radio/shark2.ko] undefined! > > Reported-by: Dadiv Rientjes > Cc: Hans de Goede > Signed-off-by: Mauro Carvalho Chehab > > > diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig > index 8090b87..be68ec2 100644 > --- a/drivers/media/radio/Kconfig > +++ b/drivers/media/radio/Kconfig > @@ -60,6 +60,7 @@ config RADIO_MAXIRADIO > config RADIO_SHARK > tristate "Griffin radioSHARK USB radio receiver" > depends on USB && SND > + select LEDS_CLASS > ---help--- > Choose Y here if you have this radio receiver. > > @@ -77,6 +78,7 @@ config RADIO_SHARK > config RADIO_SHARK2 > tristate "Griffin radioSHARK2 USB radio receiver" > depends on USB > + select LEDS_CLASS > ---help--- > Choose Y here if you have this radio receiver. > >