From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzWzO-0001rf-87 for qemu-devel@nongnu.org; Thu, 09 Aug 2012 13:57:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzWzN-000883-0Q for qemu-devel@nongnu.org; Thu, 09 Aug 2012 13:57:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7259) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzWzM-00087o-MJ for qemu-devel@nongnu.org; Thu, 09 Aug 2012 13:57:40 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q79HvdOn018767 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 9 Aug 2012 13:57:39 -0400 Message-ID: <5023FA12.2030005@redhat.com> Date: Thu, 09 Aug 2012 11:57:38 -0600 From: Eric Blake MIME-Version: 1.0 References: <1344533300-6422-1-git-send-email-lcapitulino@redhat.com> <1344533300-6422-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1344533300-6422-3-git-send-email-lcapitulino@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigB34BDF95644812265D54BABD" Subject: Re: [Qemu-devel] [PATCH 2/4] qmp: emit the WAKEUP event when the guest is put to run List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org, kraxel@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB34BDF95644812265D54BABD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/09/2012 11:28 AM, Luiz Capitulino wrote: > Today, the WAKEUP event is emitted when a wakeup _request_ is made. > This could be the system_wakeup command, for example. >=20 > A better semantic would be to emit the event when the guest is > already running, as that's what matters in the end. This commit does > that change. >=20 > In theory, this could break compatibility. In practice, it shouldn't > happen though, as clients shouldn't rely on timing characteristics of > the events. That is, a client relying that the guest is not running > when the event arrives may break if the event arrives after the guest > is already running. Yeah, no problem with that semantic change from libvirt. > +WAKEUP > +------ > + > +Emitted when the guest has been waken up from S3 and is running. grammar: s/has been waken/has woken/ or maybe s/has been waken up/has been awakened/ --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigB34BDF95644812265D54BABD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQI/oTAAoJEKeha0olJ0NqLA0H/3jmyvkSpVjJagFCCZ2APhHo /9WfUMh/IYYOZ0S3YNL9i2Xc12x9h9KljS6EC6qDjMCOe4cO72pD483nkb/ZEWlP 6LZ5WQ3P7Xs2pAUrqteAQEveSvTf7upKHQnT3l41xJ8bvgU5z0wIlFphHRz9TXws pgKuHBmM+zHE8mN962dAhYp1JSSd7qCwd9IOAi2khJgpjhBZT2X95E0N0OpenxSo YmUMd7iEMYIaEYhSmCoOaz4XTuDhAEapkizxLX9q0oDr4RRikj2HiNga/DKc5P2X omMIUhgkk8+qMZntkSFVBzV3xlpiZMvzpCwZkOGe8eOYGtXz9iwhGqd9Iobu1vo= =kUvV -----END PGP SIGNATURE----- --------------enigB34BDF95644812265D54BABD--