From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzYQM-00066Z-U8 for qemu-devel@nongnu.org; Thu, 09 Aug 2012 15:29:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzYQL-0008Mg-4L for qemu-devel@nongnu.org; Thu, 09 Aug 2012 15:29:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27936) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzYQK-0008Mc-S4 for qemu-devel@nongnu.org; Thu, 09 Aug 2012 15:29:37 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q79JTais011922 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 9 Aug 2012 15:29:36 -0400 Message-ID: <50240F9C.30202@redhat.com> Date: Thu, 09 Aug 2012 13:29:32 -0600 From: Eric Blake MIME-Version: 1.0 References: <1344533300-6422-1-git-send-email-lcapitulino@redhat.com> <1344533300-6422-4-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1344533300-6422-4-git-send-email-lcapitulino@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig9C095F07CDE87C4601D1345E" Subject: Re: [Qemu-devel] [PATCH 3/4] qmp: qmp-events.txt: put events in alphabetical order List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org, kraxel@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig9C095F07CDE87C4601D1345E Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/09/2012 11:28 AM, Luiz Capitulino wrote: > Signed-off-by: Luiz Capitulino > --- > QMP/qmp-events.txt | 266 ++++++++++++++++++++++++++-------------------= -------- > 1 file changed, 130 insertions(+), 136 deletions(-) Code motion that deletes 6 more lines than it adds? I'm assuming those were blank lines, and that spacing is more consistent now, but it's nicer to see a code motion patch with matching diffstat. Reviewed-by: Eric Blake >=20 > diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt > index b8afedb..e37a04e 100644 > --- a/QMP/qmp-events.txt > +++ b/QMP/qmp-events.txt Nits to possibly address in a followup patch (do NOT fix them at the same time as code motion, though): > =20 > +SPICE_CONNECTED, SPICE_DISCONNECTED > +----------------------------------- > + > +Emitted when a SPICE client connects or disconnects. Should this be broken into two listings? > +SPICE_INITIALIZED > +----------------- > + > +Emitted after initial handshake and authentication takes place (if any= ) > +and the SPICE channel is up'n'running Do we like this cutesy abbreviation, or should we spell out 'and'? > + > +Data: > + > +- "server": Server information (json-object) > + - "host": IP address (json-string) > + - "port": port number (json-string) > + - "family": address family (json-string, "ipv4" or "ipv6") > + - "auth": authentication method (json-string, optional) > +- "client": Client information (json-object) > + - "host": IP address (json-string) > + - "port": port number (json-string) > + - "family": address family (json-string, "ipv4" or "ipv6") > + - "connection-id": spice connection id. All channels with the same = id > + belong to the same spice session (json-int) > + - "channel-type": channel type. "1" is the main control channel, fi= lter for > + this one if you want track spice sessions only (js= on-int) > + - "channel-id": channel id. Usually "0", might be different needed = when > + multiple channels of the same type exist, such as mu= ltiple > + display channels in a multihead setup (json-int) > + - "tls": whevener the channel is encrypted (json-bool) s/whevener/whether/ --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig9C095F07CDE87C4601D1345E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQJA+dAAoJEKeha0olJ0Nqi00H/211rjdPLMMDCJ7wvAfGmNkJ MSDjAgxDYc657CSaGhKAA6t4A/HjycumQovIv0XRnm1NDxBUb5hZ6OfMRyou3rPV PJZEwKvq2Z4JKAj0VQB2HeNblSdCqJoqFAhriKEf1jg0n8BvPtUWBOEYOmyPzCn9 wNoL1lt8T7uT+TMzxhhKUj0yPMiKDjX5rGeDRwhPVcndVZiaxKf1LHi7wIkHdMsv lUoStiFWufE4mU5mafJF+rb3xJRMZbj2z2GiS3rM0cteK/mgJxuom6kg8LkXJUp4 c5HH+JBK/3Y8rsCoD93Hr2HEZfTgAER5dheLzaTEXSXeF2W+IQPJUL9Ej7OqKfE= =coR8 -----END PGP SIGNATURE----- --------------enig9C095F07CDE87C4601D1345E--