From mboxrd@z Thu Jan 1 00:00:00 1970 From: DrEagle Date: Tue, 14 Aug 2012 14:33:24 +0200 Subject: [U-Boot] [PATCH] fix IDE_BUS(dev) macro In-Reply-To: <20120813142716.75a0d647@aari01-12> References: <20120417190649.GA22913@w500.iskon.local> <4F8FB2DB.5090502@aribaud.net> <20120429201941.GA6293@w500.iskon.local> <20120514192910.GA23116@w500.iskon.local> <4FB2B1C3.2020503@aribaud.net> <20120607133043.GB578@w500.iskon.local> <20120809203633.7FD7720401A@gemini.denx.de> <20120813142716.75a0d647@aari01-12> Message-ID: <502A4594.6040901@doukki.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, It works great for my IB-6220 (Dual Sata). Without the patch, the same disk is seen twice, I have only checked disks serial numbers : ib62x0 => version U-Boot 2012.07-00123-g4d3c95f-dirty (Aug 13 2012 - 11:30:58) RaidSonic ICY BOX IB-NAS62x0 arm-linux-gnueabi-gcc (Debian 4.4.5-8) 4.4.5 GNU ld (GNU Binutils for Debian) 2.20.1.20100303 ib62x0 => ide reset Reset IDE: Bus 0: OK Bus 1: OK Device 0: Model: WDC WD20EARX-00MMMB0 Firm: 80.00A80 Ser#: WD-WCAWZ2075392 Type: Hard Disk Supports 48-bit addressing Capacity: 1907729.0 MB = 1863.0 GB (-387938128 x 512) Device 1: Model: WDC WD20EARX-00MMMB0 Firm: 80.00A80 Ser#: WD-WCAWZ2075392 Type: Hard Disk Supports 48-bit addressing Capacity: 1907729.0 MB = 1863.0 GB (-387938128 x 512) ib62x0 => --- With the patch applied, the two disks are seen : --- patch -p0 -i ../fix_ide.diff File to patch: include/ide.h ib62x0 => version U-Boot 2012.07-00123-g4d3c95f-dirty (Aug 14 2012 - 14:22:49) RaidSonic ICY BOX IB-NAS62x0 arm-linux-gnueabi-gcc (Debian 4.4.5-8) 4.4.5 GNU ld (GNU Binutils for Debian) 2.20.1.20100303 ib62x0 => ide reset Reset IDE: Bus 0: OK Bus 1: OK Device 0: Model: WDC WD20EARX-00MMMB0 Firm: 80.00A80 Ser#: WD-WCAWZ2075392 Type: Hard Disk Supports 48-bit addressing Capacity: 1907729.0 MB = 1863.0 GB (-387938128 x 512) Device 1: Model: WDC WD20EARX-00MMMB0 Firm: 80.00A80 Ser#: WD-WCAWZ2083815 Type: Hard Disk Supports 48-bit addressing Capacity: 1907729.0 MB = 1863.0 GB (-387938128 x 512) ib62x0 => ib62x0 => ide device 0 IDE device 0: Model: WDC WD20EARX-00MMMB0 Firm: 80.00A80 Ser#: WD-WCAWZ2075392 Type: Hard Disk Supports 48-bit addressing Capacity: 1907729.0 MB = 1863.0 GB (-387938128 x 512) ... is now current device ib62x0 => ide device 1 IDE device 1: Model: WDC WD20EARX-00MMMB0 Firm: 80.00A80 Ser#: WD-WCAWZ2083815 Type: Hard Disk Supports 48-bit addressing Capacity: 1907729.0 MB = 1863.0 GB (-387938128 x 512) ... is now current device --- For me this patch has fixed the detection bug of ide disks. Hope this tests may help. Le 13/08/2012 14:27, Albert ARIBAUD a ?crit : > Hi Wolfgang, > > On Thu, 09 Aug 2012 22:36:33 +0200, Wolfgang Denk wrote: >> Dear Albert ARIBAUD, >> >> In message >> >> you wrote: >>> Sorry Luka (and all), been tied up pretty heavily recently, had to >>> adjust to find some free time again. >>> >>> I will test your patch today and post results tonight. >> >> What was the outcome of this? I cannot find any further messages to >> this thread... > > Sorry, I was away from home for a few days with no or little Internet > access. > > I wanted to test this on orion5x/edminiv2; I should be able to do this > today in the course of regression-testing preparing an orion5x patch > I want to submit in this window. > >> Best regards, >> >> Wolfgang Denk > > Amicalement, > drEagle