Re: [Qemu-devel] [PATCH 17/23] mips_malta mips_r4k: Suppress unused default drives

[Stefan Weil <sw@weilnetz.de>]

Am 09.08.2012 15:31, schrieb Markus Armbruster:
> Cc: Aurelien Jarno <aurelien@aurel32.net>
>
> Suppress default SD card drive for machines malta, mips.
>
> Suppress default floppy drive for machine mips.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   hw/mips_malta.c | 1 +
>   hw/mips_r4k.c   | 2 ++
>   2 files changed, 3 insertions(+)
>
> diff --git a/hw/mips_malta.c b/hw/mips_malta.c
> index 351c88e..c1c52ac 100644
> --- a/hw/mips_malta.c
> +++ b/hw/mips_malta.c
> @@ -1019,6 +1019,7 @@ static QEMUMachine mips_malta_machine = {
>       .desc = "MIPS Malta Core LV",
>       .init = mips_malta_init,
>       .max_cpus = 16,
> +    .no_sdcard = 1,
>       .is_default = 1,
>   };
>   
> diff --git a/hw/mips_r4k.c b/hw/mips_r4k.c
> index 967a76e..d9f6dc5 100644
> --- a/hw/mips_r4k.c
> +++ b/hw/mips_r4k.c
> @@ -299,6 +299,8 @@ static QEMUMachine mips_machine = {
>       .name = "mips",
>       .desc = "mips r4k platform",
>       .init = mips_r4k_init,
> +    .no_floppy = 1,
> +    .no_sdcard = 1,
>   };
>   
>   static void mips_machine_init(void)

Reviewed-by: Stefan Weil <sw@weilnetz.de>

I'd prefer using 'true' instead of '1' (and changing the
variables to type bool), but that can be done later.

Regards,

Stefan W.