From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2 2/4] ethdev: add siblings iterators Date: Tue, 19 Mar 2019 18:04:34 +0000 Message-ID: <50312a9a-884b-cc7d-24cd-c01a34cc22e7@intel.com> References: <20181130002716.27325-1-thomas@monjalon.net> <20190220221051.7928-3-thomas@monjalon.net> <0f5b0dc3-05c6-0f64-1643-7fc23aebfc0a@intel.com> <59747746.vl7xl9E5pD@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Andrew Rybchenko , dev@dpdk.org To: Thomas Monjalon Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id A41891DBD for ; Tue, 19 Mar 2019 19:04:36 +0100 (CET) In-Reply-To: <59747746.vl7xl9E5pD@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/19/2019 5:34 PM, Thomas Monjalon wrote: >>> +uint16_t __rte_experimental >> Do we need _rte_experimental on function definitions? I guess only in .h file, >> function declaration is enough. > Yes we need them both in .h and .c files. > Why we need them in .c file? I think the compiler is interested in ones in .h file, because of the experimental checks.