From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C024EC388F7 for ; Tue, 3 Nov 2020 20:05:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C14C22277 for ; Tue, 3 Nov 2020 20:05:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="Ow5SVZ/x" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729734AbgKCUF0 (ORCPT ); Tue, 3 Nov 2020 15:05:26 -0500 Received: from linux.microsoft.com ([13.77.154.182]:36156 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725997AbgKCUF0 (ORCPT ); Tue, 3 Nov 2020 15:05:26 -0500 Received: from [192.168.0.104] (c-73-42-176-67.hsd1.wa.comcast.net [73.42.176.67]) by linux.microsoft.com (Postfix) with ESMTPSA id B307F20B4905; Tue, 3 Nov 2020 12:05:24 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B307F20B4905 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1604433925; bh=FpRaU+1eA08DHDzzs2SLgSYuS0jFUegfVIwGSw2MrPM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Ow5SVZ/xuAOhzp4Gps8tIL5ExIsBerckCwQ+gbwRldD48gb0cbTNKextoK9tcQLE8 QIZpQOczJZO+5O9w6sd6HuJlKll9ibyG9qnXqVGlM07/NVnPTttih9uLvj6lxSVUEH gFTDxBqxhYtJBY60Ky5uwXO3lRaqmh0dbY5qDM4k= Subject: Re: [PATCH v8 2/4] powerpc: Refactor kexec functions to move arch independent code to ima To: Mimi Zohar , bauerman@linux.ibm.com, robh@kernel.org, gregkh@linuxfoundation.org, james.morse@arm.com, catalin.marinas@arm.com, sashal@kernel.org, will@kernel.org, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, robh+dt@kernel.org, frowand.list@gmail.com, vincenzo.frascino@arm.com, mark.rutland@arm.com, dmitry.kasatkin@gmail.com, jmorris@namei.org, serge@hallyn.com, pasha.tatashin@soleen.com, allison@lohutok.net, kstewart@linuxfoundation.org, takahiro.akashi@linaro.org, tglx@linutronix.de, masahiroy@kernel.org, bhsharma@redhat.com, mbrugger@suse.com, hsinyi@chromium.org, tao.li@vivo.com, christophe.leroy@c-s.fr Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, prsriva@linux.microsoft.com, balajib@linux.microsoft.com References: <20201030174429.29893-1-nramas@linux.microsoft.com> <20201030174429.29893-3-nramas@linux.microsoft.com> <87f63dc12739b346d556f85537324d3ae055097d.camel@linux.ibm.com> <397f1bbf-46bf-b522-616b-2e006ef30e70@linux.microsoft.com> From: Lakshmi Ramasubramanian Message-ID: <5032768c-779b-a03f-aacc-0c2da51ecc87@linux.microsoft.com> Date: Tue, 3 Nov 2020 12:05:24 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/3/20 11:50 AM, Mimi Zohar wrote: > On Tue, 2020-11-03 at 11:23 -0800, Lakshmi Ramasubramanian wrote: >> On 11/3/20 6:55 AM, Mimi Zohar wrote: >> >> Hi Mimi, >> >>> >>> On Fri, 2020-10-30 at 10:44 -0700, Lakshmi Ramasubramanian wrote: >>>> The functions ima_get_kexec_buffer() and ima_free_kexec_buffer(), >>>> that handle carrying forward the IMA measurement logs on kexec for >>>> powerpc do not have architecture specific code, but they are currently >>>> defined for powerpc only. >>>> >>>> Move ima_get_kexec_buffer() and ima_free_kexec_buffer() to IMA >>>> subsystem. A later patch in this series will use these functions for >>>> carrying forward the IMA measurement log for ARM64. >>>> >>>> With the above refactoring arch/powerpc/kexec/ima.c contains only >>>> functions used when CONFIG_IMA_KEXEC is enabled. Update Makefile >>>> in arch/powerpc/kexec to include arch/powerpc/kexec/ima.c only >>>> when CONFIG_IMA_KEXEC is enabled. >>>> >>>> Co-developed-by: Prakhar Srivastava >>>> Signed-off-by: Prakhar Srivastava >>>> Signed-off-by: Lakshmi Ramasubramanian >>> >>> Similar comments to 1/4. >>> - Last line of first paragraph can be rephrased like " ... on kexec, >>> do not contain architecture specific code, but are currently limited to >>> powerpc." >> Sure. >> >>> - This patch should be limited to moving existing functions. >>> Truncate the Subject line to "Move arch independent IMA kexec functions >>> to ima_kexec.c." >> Will do. >> >>> - Don't refer to a later patch, but explain the purpose here. For >>> example, "Move ... , making them accessible to other archs." >> Sure. >> >>> - The definition of "FDT_PROP_IMA_KEXEC_BUFFER" should be made as a >>> separate, prepartory patch, prior to the existing 1/4. The resulting >>> code being moved in this patch (and similarly for 1/4) will be exactly >>> the same as the code being deleted. >> >> Definition of FDT_PROP_IMA_KEXEC_BUFFER will be made as a preparatory >> patch as you'd mentioned in the comments for [PATCH 1/4]. >> >> Will split [PATCH 2/4] as listed below: >> >> PATCH #1: Move ima_get_kexec_buffer() and ima_free_kexec_buffer() to >> IMA, along with deleting them in arch/powerpc/kexec/ima.c > > No, other than the comments above, this patch is fine. It moves > ima_get_kexec_buffer() and ima_free_kexec_buffer() to ima_kexec.c. > Ok - I will do the updates in the patch description only and keep the code changes as is. Thanks for clarifying. -lakshmi