From: John Allen <jallen@linux.vnet.ibm.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org,
Thomas Falcon <tlfalcon@linux.vnet.ibm.com>,
Nathan Fontenot <nfont@linux.vnet.ibm.com>
Subject: Re: [PATCH net-next v2] ibmvnic: Bail from ibmvnic_open if driver is already open
Date: Mon, 12 Mar 2018 15:12:18 -0500 [thread overview]
Message-ID: <503418ff-323d-8eda-16c4-73c9918b38e7@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180312201002.GC31588@lunn.ch>
On 03/12/2018 03:10 PM, Andrew Lunn wrote:
>> The problem here is that our routine to change the mtu does a full reset on
>> the driver meaning that in the process we go from effectively "open" to
>> "closed" to "open" again.
>>
>> Consider the scenario where we change the mtu by running "ifdown <interface>",
>> editing the ifcfg file with the new mtu, and finally running "ifup <interface".
>> In this case, we call ibmvnic_close from the ifdown and as a result of the ifup,
>> we do the reset for the mtu change (which puts us back in the "open" state) and
>> call ibmvnic_open. After the reset, we are already in the "open" state and the
>> following call to open is redundant.
>
> Hi John
>
> So you are saying "ip link set mtu 4242 eth1" on a down interface will
> put it up. That i would say is broken. You should be fixing this,
> rather than papering over the cracks.
That's a good point. I'll work on a fix to address that.
-John
>
> Andrew
>
>
prev parent reply other threads:[~2018-03-12 20:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 19:19 [PATCH net-next v2] ibmvnic: Bail from ibmvnic_open if driver is already open John Allen
2018-03-12 19:33 ` Andrew Lunn
2018-03-12 19:56 ` John Allen
2018-03-12 20:10 ` Andrew Lunn
2018-03-12 20:12 ` John Allen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503418ff-323d-8eda-16c4-73c9918b38e7@linux.vnet.ibm.com \
--to=jallen@linux.vnet.ibm.com \
--cc=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
--cc=nfont@linux.vnet.ibm.com \
--cc=tlfalcon@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.