From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030432AbcCQMEh (ORCPT ); Thu, 17 Mar 2016 08:04:37 -0400 Received: from mail9.hitachi.co.jp ([133.145.228.44]:41818 "EHLO mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030264AbcCQMEf (ORCPT ); Thu, 17 Mar 2016 08:04:35 -0400 From: =?gb2312?B?xr3LydHFy8ggLyBISVJBTUFUVaOsTUFTQU1J?= To: "'David Long'" , Catalin Marinas , Will Deacon , Sandeepa Prabhu , William Cohen , "Pratyush Anand" , Steve Capper , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Marc Zyngier CC: Mark Rutland , Petr Mladek , Viresh Kumar , John Blackwood , Feng Kan , Zi Shen Lim , Dave P Martin , Yang Shi , Vladimir Murzin , Kees Cook , "Suzuki K. Poulose" , "Mark Brown" , =?gb2312?B?QWxleCBCZW5uqKZl?= , Ard Biesheuvel , "Greg Kroah-Hartman" , Mark Salyzyn , James Morse , Christoffer Dall , Andrew Morton , Robin Murphy , Jens Wiklander , Balamurugan Shanmugam , sysp-manager Subject: RE: [PATCH v11 3/9] arm64: add copy_to/from_user to kprobes blacklist Thread-Topic: [!][PATCH v11 3/9] arm64: add copy_to/from_user to kprobes blacklist Thread-Index: AQHRecVBKxJWiebga02QNWs4y5chfZ9dlnLg Date: Thu, 17 Mar 2016 12:04:30 +0000 Message-ID: <50399556C9727B4D88A595C8584AAB37B4E50343@GSjpTKYDCembx32.service.hitachi.net> References: <1457501543-24197-1-git-send-email-dave.long@linaro.org> <1457501543-24197-4-git-send-email-dave.long@linaro.org> In-Reply-To: <1457501543-24197-4-git-send-email-dave.long@linaro.org> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.198.219.31] Content-Type: text/plain; charset="gb2312" MIME-Version: 1.0 X-TM-AS-GCONF: 00 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u2HC4gQo018838 >From: "David A. Long" > >Currrently taking exceptions when accessing user data from a kprobe'd >instruction doesn't work. Avoid this situation by blacklisting the relevant >functions. > >Signed-off-by: David A. Long Looks good to me. Reviewed-by: Masami Hiramatsu Thanks, >--- > arch/arm64/lib/copy_from_user.S | 1 + > arch/arm64/lib/copy_to_user.S | 1 + > 2 files changed, 2 insertions(+) > >diff --git a/arch/arm64/lib/copy_from_user.S b/arch/arm64/lib/copy_from_user.S >index 4699cd7..0ac2131 100644 >--- a/arch/arm64/lib/copy_from_user.S >+++ b/arch/arm64/lib/copy_from_user.S >@@ -66,6 +66,7 @@ > .endm > > end .req x5 >+ .section .kprobes.text,"ax",%progbits > ENTRY(__copy_from_user) > ALTERNATIVE("nop", __stringify(SET_PSTATE_PAN(0)), ARM64_HAS_PAN, \ > CONFIG_ARM64_PAN) >diff --git a/arch/arm64/lib/copy_to_user.S b/arch/arm64/lib/copy_to_user.S >index 7512bbb..e4eb84c 100644 >--- a/arch/arm64/lib/copy_to_user.S >+++ b/arch/arm64/lib/copy_to_user.S >@@ -65,6 +65,7 @@ > .endm > > end .req x5 >+ .section .kprobes.text,"ax",%progbits > ENTRY(__copy_to_user) > ALTERNATIVE("nop", __stringify(SET_PSTATE_PAN(0)), ARM64_HAS_PAN, \ > CONFIG_ARM64_PAN) >-- >2.5.0 > > >_______________________________________________ >linux-arm-kernel mailing list >linux-arm-kernel@lists.infradead.org >http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: masami.hiramatsu.pt@hitachi.com (=?gb2312?B?xr3LydHFy8ggLyBISVJBTUFUVaOsTUFTQU1J?=) Date: Thu, 17 Mar 2016 12:04:30 +0000 Subject: [PATCH v11 3/9] arm64: add copy_to/from_user to kprobes blacklist In-Reply-To: <1457501543-24197-4-git-send-email-dave.long@linaro.org> References: <1457501543-24197-1-git-send-email-dave.long@linaro.org> <1457501543-24197-4-git-send-email-dave.long@linaro.org> Message-ID: <50399556C9727B4D88A595C8584AAB37B4E50343@GSjpTKYDCembx32.service.hitachi.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org >From: "David A. Long" > >Currrently taking exceptions when accessing user data from a kprobe'd >instruction doesn't work. Avoid this situation by blacklisting the relevant >functions. > >Signed-off-by: David A. Long Looks good to me. Reviewed-by: Masami Hiramatsu Thanks, >--- > arch/arm64/lib/copy_from_user.S | 1 + > arch/arm64/lib/copy_to_user.S | 1 + > 2 files changed, 2 insertions(+) > >diff --git a/arch/arm64/lib/copy_from_user.S b/arch/arm64/lib/copy_from_user.S >index 4699cd7..0ac2131 100644 >--- a/arch/arm64/lib/copy_from_user.S >+++ b/arch/arm64/lib/copy_from_user.S >@@ -66,6 +66,7 @@ > .endm > > end .req x5 >+ .section .kprobes.text,"ax",%progbits > ENTRY(__copy_from_user) > ALTERNATIVE("nop", __stringify(SET_PSTATE_PAN(0)), ARM64_HAS_PAN, \ > CONFIG_ARM64_PAN) >diff --git a/arch/arm64/lib/copy_to_user.S b/arch/arm64/lib/copy_to_user.S >index 7512bbb..e4eb84c 100644 >--- a/arch/arm64/lib/copy_to_user.S >+++ b/arch/arm64/lib/copy_to_user.S >@@ -65,6 +65,7 @@ > .endm > > end .req x5 >+ .section .kprobes.text,"ax",%progbits > ENTRY(__copy_to_user) > ALTERNATIVE("nop", __stringify(SET_PSTATE_PAN(0)), ARM64_HAS_PAN, \ > CONFIG_ARM64_PAN) >-- >2.5.0 > > >_______________________________________________ >linux-arm-kernel mailing list >linux-arm-kernel at lists.infradead.org >http://lists.infradead.org/mailman/listinfo/linux-arm-kernel