From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7DeJ-0003wy-Q8 for qemu-devel@nongnu.org; Thu, 30 Aug 2012 18:55:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T7DeI-0001yX-4t for qemu-devel@nongnu.org; Thu, 30 Aug 2012 18:55:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39332) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7DeH-0001yR-ND for qemu-devel@nongnu.org; Thu, 30 Aug 2012 18:55:41 -0400 Message-ID: <503FEF68.1080002@redhat.com> Date: Thu, 30 Aug 2012 15:55:36 -0700 From: Eric Blake MIME-Version: 1.0 References: <6dfa5019b22f1d72b1b02ba14efc9766fcb6e0a9.1346351079.git.jcody@redhat.com> In-Reply-To: <6dfa5019b22f1d72b1b02ba14efc9766fcb6e0a9.1346351079.git.jcody@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigF454CFA32C5E1E3E33F561E1" Subject: Re: [Qemu-devel] [RFC v2 PATCH 4/6] qerror: new error for live block commit, QERR_TOP_NOT_FOUND List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, supriyak@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF454CFA32C5E1E3E33F561E1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/30/2012 11:47 AM, Jeff Cody wrote: > Signed-off-by: Jeff Cody > --- > qerror.h | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/qerror.h b/qerror.h > index d0a76a4..7396184 100644 > --- a/qerror.h > +++ b/qerror.h > @@ -219,6 +219,9 @@ void assert_no_error(Error *err); > #define QERR_TOO_MANY_FILES \ > ERROR_CLASS_GENERIC_ERROR, "Too many open files" > =20 > +#define QERR_TOP_NOT_FOUND \ > + ERROR_CLASS_GENERIC_ERROR, "Top image file %s not found" > + Are you sure this patch is needed, or should you be using error_setg()? http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg04980.html --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigF454CFA32C5E1E3E33F561E1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQP+9oAAoJEKeha0olJ0NqdHMH/3XblMCZw2fa4pcmAsW7JRZ5 Ry0/vZWCNxh6SebhNBpME32P2W+QeROMYwbPliWQr7Vg8uF98TRmFZMMo1sjTVQK sJqhpoA1/wQTWluz7t/yvz9VWJ2qZIUf/0dcLvIE2htdsRnyLyy7s8S+tu9qZVEl H6G8k0rR7WWIcBxq/DbCXVhQTJhC/PY8U/fFcsyAsm7/u4hKMg6WIOGLVEOCxKpM A1SZujr6Mi11Jc428I3jhQmbL1iXWhPIQl4xOfSoIMGZe+OvPkuw6nbMiqAKnLpd vPcnlQ1GPD2uNzgZ7V0nBJL1b8oiQOwt2Ld5zm6Yw25dNMP683fx3XhV1n5mkLU= =sYKT -----END PGP SIGNATURE----- --------------enigF454CFA32C5E1E3E33F561E1--