From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3335FC433DF for ; Wed, 12 Aug 2020 10:58:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F143C208E4 for ; Wed, 12 Aug 2020 10:58:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Px4MzpFx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727066AbgHLK6y (ORCPT ); Wed, 12 Aug 2020 06:58:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727801AbgHLKyl (ORCPT ); Wed, 12 Aug 2020 06:54:41 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13A75C06174A for ; Wed, 12 Aug 2020 03:54:11 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id g8so1379528wmk.3 for ; Wed, 12 Aug 2020 03:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=z+jAzkAYbm8dRi6meS5Ks6bwjI53FeOFtpVqTfL46wc=; b=Px4MzpFxqro1h3xEn3hbGCmlHGC9AUOZhBWro5yZdAKbQ1CtAQQsY2R6Qg7ZveQysP eN26mgXanaiNs+6VV2GDBf1/ii/oD7QuOrGxSrZTtnWDzz44k+G9n+xzWdbN0OUOkNOD dRoleTQIaU4iodD/SbRX65KLB9QDNr/lapHwoasiy35wAfHLMiQo2PzgyfQVP3nf2mf5 AmmniBz0mCw9iVTdKZmnbx5rVJ0LQFfDjEy6AkvJes+5Hbm/6UxgvmX4rLDyyC072oqK EnCGHyJCnBIu05gAluXOeyo6nny/hdd6sfxcAJ+yeyRIYmzUW0hXmIOOo5Ya5z+6i2Su 8M4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=z+jAzkAYbm8dRi6meS5Ks6bwjI53FeOFtpVqTfL46wc=; b=RRFtaHm++JSU5ciSjeZTwjiqQw2Xkq5QNMI0DQDG5VbkcUApS7mRtisImJylP+WRW4 mhEhYyXgGg+oP96zdNGV/XjxgOn/H2Lu7+FYWTOc2GfrzfslxjY1qftrIIQg5YYJrM3x RuQEPc1wjh76ZzXROIyeqloJlK58bQhByegxgotCtwPd0jmekq3B/3ErZEExEBa5UueR UAVAjFu7kysR4Fgmq5nFmmgv1R3GJ/O5BN6yXqW5C6aMtoH0EHLeX844VetQZ022ZN1z EmbADYyp4XqrADHmH0kr9wPGea38z6RJO3jBHCQLxTGzy/wjsc6iAknCmepDb5bAMAAO EVDQ== X-Gm-Message-State: AOAM531oO1LUWLSHkhY8pvOAYwvfzJLFnbd27o2pw189UBdajRPtVW6D vrfYiNUsVHLvh2yJ+rCV0pbg3g== X-Google-Smtp-Source: ABdhPJxOX8KY3sja99cOHmyJ0eZOgpp0Zu2wnZrvweWHbVIO6LQ1fckTETTNEdKj14vX0kyacVHntw== X-Received: by 2002:a1c:4c17:: with SMTP id z23mr8426384wmf.49.1597229649440; Wed, 12 Aug 2020 03:54:09 -0700 (PDT) Received: from [192.168.1.14] ([195.24.90.54]) by smtp.googlemail.com with ESMTPSA id r11sm3424811wrw.78.2020.08.12.03.54.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Aug 2020 03:54:08 -0700 (PDT) Subject: Re: [PATCH v2] media: venus: Fix reported frame intervals To: Loic Poulain , stanimir.varbanov@linaro.org Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, anibal.limon@linaro.org References: <1596543717-9106-1-git-send-email-loic.poulain@linaro.org> From: Stanimir Varbanov Message-ID: <503a3674-0697-8955-f0c2-109e5f700e41@linaro.org> Date: Wed, 12 Aug 2020 13:54:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1596543717-9106-1-git-send-email-loic.poulain@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Loic, Thanks for the patch! On 8/4/20 3:21 PM, Loic Poulain wrote: > On dragonboard-410c (apq8016) with HFI_VERSION_1XX, the reported > framerate is in unit of 1/65535 fps (for fine grained control). > So the current reported supported frame intervals is wrong (max > is 1/65535 fps), leading to encoding issues or format negotiation > failures with gstreamer. > > Fix that by setting the framerate denominator to coherent value > based on the the framerate factor. > > The factor is not always the same, e.g. with db820c (apq8096) HFI > reports framerate in fps unit. So only apply that for HFI_VERSION_1XX. > > Signed-off-by: Loic Poulain > --- > v2: Use IS_V1 helper for retrieveing venus core version > Adjust denominator instead of numerator > > drivers/media/platform/qcom/venus/venc.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) Acked-by: Stanimir Varbanov > > diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c > index 9981a2a..5b3df09 100644 > --- a/drivers/media/platform/qcom/venus/venc.c > +++ b/drivers/media/platform/qcom/venus/venc.c > @@ -576,6 +576,7 @@ static int venc_enum_frameintervals(struct file *file, void *fh, > { > struct venus_inst *inst = to_inst(file); > const struct venus_format *fmt; > + unsigned int framerate_factor = 1; > > fival->type = V4L2_FRMIVAL_TYPE_STEPWISE; > > @@ -600,12 +601,17 @@ static int venc_enum_frameintervals(struct file *file, void *fh, > fival->height < frame_height_min(inst)) > return -EINVAL; > > + if (IS_V1(inst->core)) { > + /* framerate is reported in 1/65535 fps unit */ > + framerate_factor = (1 << 16); > + } > + > fival->stepwise.min.numerator = 1; > - fival->stepwise.min.denominator = frate_max(inst); > + fival->stepwise.min.denominator = frate_max(inst) / framerate_factor; > fival->stepwise.max.numerator = 1; > - fival->stepwise.max.denominator = frate_min(inst); > + fival->stepwise.max.denominator = frate_min(inst) / framerate_factor; > fival->stepwise.step.numerator = 1; > - fival->stepwise.step.denominator = frate_max(inst); > + fival->stepwise.step.denominator = frate_max(inst) / framerate_factor; > > return 0; > } > -- regards, Stan