From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2D7AC4338F for ; Thu, 29 Jul 2021 02:03:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D63C6056C for ; Thu, 29 Jul 2021 02:03:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233241AbhG2CDL (ORCPT ); Wed, 28 Jul 2021 22:03:11 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:12419 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233162AbhG2CDK (ORCPT ); Wed, 28 Jul 2021 22:03:10 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4GZty16sw9zcjKF; Thu, 29 Jul 2021 09:59:37 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 29 Jul 2021 10:02:56 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 29 Jul 2021 10:02:56 +0800 Subject: Re: [PATCH v2 6/7] sections: Add new is_kernel() and is_kernel_text() To: Steven Rostedt CC: , , , , , , , , , , References: <20210728081320.20394-1-wangkefeng.wang@huawei.com> <20210728081320.20394-7-wangkefeng.wang@huawei.com> <20210728113204.67fa6dfc@oasis.local.home> From: Kefeng Wang Message-ID: <503b712c-ae62-ae05-907d-7bca67a2b00a@huawei.com> Date: Thu, 29 Jul 2021 10:02:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20210728113204.67fa6dfc@oasis.local.home> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/7/28 23:32, Steven Rostedt wrote: > On Wed, 28 Jul 2021 16:13:19 +0800 > Kefeng Wang wrote: > >> @@ -64,8 +64,7 @@ const struct exception_table_entry *search_exception_tables(unsigned long addr) >> >> int notrace core_kernel_text(unsigned long addr) >> { >> - if (addr >= (unsigned long)_stext && >> - addr < (unsigned long)_etext) >> + if (is_kernel_text(addr)) > Perhaps this was a bug, and these functions should be checking the gate > area as well, as that is part of kernel text. Ok, I would fix this if patch5 is reviewed well. > > -- Steve > > >> return 1; >> >> if (system_state < SYSTEM_RUNNING && >> diff --git a/mm/kasan/report.c b/mm/kasan/report.c >> index 884a950c7026..88f5b0c058b7 100644 >> --- a/mm/kasan/report.c >> +++ b/mm/kasan/report.c >> @@ -235,7 +235,7 @@ static void describe_object(struct kmem_cache *cache, void *object, >> >> static inline bool kernel_or_module_addr(const void *addr) >> { >> - if (addr >= (void *)_stext && addr < (void *)_end) >> + if (is_kernel((unsigned long)addr)) >> return true; >> if (is_module_address((unsigned long)addr)) >> return true; >> -- > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73705C432BE for ; Thu, 29 Jul 2021 02:03:32 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC0F16103B for ; Thu, 29 Jul 2021 02:03:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DC0F16103B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GZv2V213Wz30DH for ; Thu, 29 Jul 2021 12:03:30 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=huawei.com (client-ip=45.249.212.188; helo=szxga02-in.huawei.com; envelope-from=wangkefeng.wang@huawei.com; receiver=) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GZv272xtsz2xfy for ; Thu, 29 Jul 2021 12:03:11 +1000 (AEST) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4GZty16sw9zcjKF; Thu, 29 Jul 2021 09:59:37 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 29 Jul 2021 10:02:56 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 29 Jul 2021 10:02:56 +0800 Subject: Re: [PATCH v2 6/7] sections: Add new is_kernel() and is_kernel_text() To: Steven Rostedt References: <20210728081320.20394-1-wangkefeng.wang@huawei.com> <20210728081320.20394-7-wangkefeng.wang@huawei.com> <20210728113204.67fa6dfc@oasis.local.home> From: Kefeng Wang Message-ID: <503b712c-ae62-ae05-907d-7bca67a2b00a@huawei.com> Date: Thu, 29 Jul 2021 10:02:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20210728113204.67fa6dfc@oasis.local.home> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, ryabinin.a.a@gmail.com, arnd@arndb.de, linux-kernel@vger.kernel.org, ast@kernel.org, mingo@redhat.com, paulus@samba.org, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 2021/7/28 23:32, Steven Rostedt wrote: > On Wed, 28 Jul 2021 16:13:19 +0800 > Kefeng Wang wrote: > >> @@ -64,8 +64,7 @@ const struct exception_table_entry *search_exception_tables(unsigned long addr) >> >> int notrace core_kernel_text(unsigned long addr) >> { >> - if (addr >= (unsigned long)_stext && >> - addr < (unsigned long)_etext) >> + if (is_kernel_text(addr)) > Perhaps this was a bug, and these functions should be checking the gate > area as well, as that is part of kernel text. Ok, I would fix this if patch5 is reviewed well. > > -- Steve > > >> return 1; >> >> if (system_state < SYSTEM_RUNNING && >> diff --git a/mm/kasan/report.c b/mm/kasan/report.c >> index 884a950c7026..88f5b0c058b7 100644 >> --- a/mm/kasan/report.c >> +++ b/mm/kasan/report.c >> @@ -235,7 +235,7 @@ static void describe_object(struct kmem_cache *cache, void *object, >> >> static inline bool kernel_or_module_addr(const void *addr) >> { >> - if (addr >= (void *)_stext && addr < (void *)_end) >> + if (is_kernel((unsigned long)addr)) >> return true; >> if (is_module_address((unsigned long)addr)) >> return true; >> -- > . >