From: Jens Axboe <jaxboe@fusionio.com>
To: liang xie <xieliang007@gmail.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: [PATCH] fio: fix a doc bug(change timeout to runtime)
Date: Fri, 31 Aug 2012 08:11:10 -0700 [thread overview]
Message-ID: <5040D40E.10601@fusionio.com> (raw)
In-Reply-To: <CADu=CFo_okoQP7MDK01VgLXDKR1wDodSm39UCTLw_x+OXbj96A@mail.gmail.com>
On 2012-08-31 02:35, liang xie wrote:
> From 686c70cc5aacdc5623e4d71e566bbfef7a6abacd Mon Sep 17 00:00:00 2001
> From: xieliang <xieliang@xiaomi.com>
> Date: Fri, 31 Aug 2012 17:19:57 +0800
> Subject: [PATCH 1/1] fio:fix a doc bug(change timeout to runtime)
Your patch lacks an explanatory changelog message.
> diff --git a/README b/README
> index 8bce835..d19af4b 100644
> --- a/README
> +++ b/README
> @@ -121,7 +121,7 @@ Command line
> $ fio
> --debug Enable some debugging options (see below)
> --output Write output to file
> - --timeout Runtime in seconds
> + --runtime Runtime in seconds
They are functionally equivelant.
> @@ -138,8 +138,8 @@ $ fio
> May be "always", "never" or "auto"
> --section=name Only run specified section in job file.
> Multiple sections can be specified.
> - --alloc-size=kb Set smalloc pool to this size in kb (def 1024)
> - --warnings-fatal Fio parser warnings are fatal
> + --alloc-size=kb Set smalloc pool to this size in kb (def 1024)
> + --warnings-fatal Fio parser warnings are fatal
> --max-jobs Maximum number of threads/processes to support
> --server=args Start backend server. See Client/Server section.
> --client=host Connect to specified backend.
> @@ -161,11 +161,11 @@ options in fio. Currently the options are:
>
> process Dump info related to processes
> file Dump info related to file actions
> - io Dump info related to IO queuing
> - mem Dump info related to memory allocations
> + io Dump info related to IO queuing
> + mem Dump info related to memory allocations
> blktrace Dump info related to blktrace setup
> verify Dump info related to IO verification
> - all Enable all debug options
> + all Enable all debug options
> random Dump info related to random offset generation
> parse Dump info related to option matching and parsing
> diskutil Dump info related to disk utilization updates
Applied these.
> diff --git a/fio.1 b/fio.1
> index 5b61e43..086cf9d 100644
> --- a/fio.1
> +++ b/fio.1
> @@ -20,8 +20,8 @@ list all available tracing options.
> .BI \-\-output \fR=\fPfilename
> Write output to \fIfilename\fR.
> .TP
> -.BI \-\-timeout \fR=\fPtimeout
> -Limit run time to \fItimeout\fR seconds.
> +.BI \-\-runtime \fR=\fPruntime
> +Limit run time to \fIruntime\fR seconds.
> .TP
> .B \-\-latency\-log
> Generate per-job latency logs.
Also equivalant. But it would not hurt to mention both.
--
Jens Axboe
prev parent reply other threads:[~2012-08-31 15:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 9:35 [PATCH] fio: fix a doc bug(change timeout to runtime) liang xie
2012-08-31 15:11 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5040D40E.10601@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=fio@vger.kernel.org \
--cc=xieliang007@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.