From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AE64C433F5 for ; Thu, 9 Sep 2021 22:16:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6EB48611AD for ; Thu, 9 Sep 2021 22:16:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344614AbhIIWRf (ORCPT ); Thu, 9 Sep 2021 18:17:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343920AbhIIWRd (ORCPT ); Thu, 9 Sep 2021 18:17:33 -0400 Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D75CCC061575 for ; Thu, 9 Sep 2021 15:16:23 -0700 (PDT) Received: by mail-il1-x136.google.com with SMTP id b4so3565266ilr.11 for ; Thu, 09 Sep 2021 15:16:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zM0IXLI05yVZi63Lak4d4tbjRWxjsfvz5YtFG0Gz+D8=; b=Klq23GFlF4B4Y5HCGn+DgkvtGBGsBjnEbsQnRQ/RRIpOlGNqGJZRa4rs0KRwaBu5fG GiY+fkfvWlriXkhiqXGrVy6nGM9+olox9Mlmhl/X9GlX4Fxd+h356qCcvDF4TJiZUfnF KkggHo5WpqhZDM/J0d7ef8l8qGeNiIsXAXEPw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zM0IXLI05yVZi63Lak4d4tbjRWxjsfvz5YtFG0Gz+D8=; b=KIhbavynsPHnE2hsqPlCJQU1cWEgifOnyF5hMT/g4zeFcSZpXhjQyRldqogepb+pQo pKO9kLWKzYpXLL2kSxFDFQYCwsxHlEPFVmGrsBCIR2Lvx2QBN8gqloSwb9GwrKjG1Lsg JT/71upiNlYm3DX07cShKsFmHFZgOAahek4XxbOTPMtIU/6U/f8nUk/JAx4VfAaN+qge p4nutXy4ayUtydwIocW12OEU4ruKElEdjN7bnHFGt9QIRydcBK98Q1qeCEv92CdlAW+0 vuXtatTp2fOe4LnFVX4I//lCBgXFGICQmnmcK/kF3worCLngFZjsf0L3KzxG85lbChce 5AFA== X-Gm-Message-State: AOAM531dFnkr6T9q/0XLzoUW5zdOpqmI6FCfCaT+h3lzVVG0J7R9Z7iC H2A5TvEZfm4X8FVlgkucDR5QJfndbFxXKQ== X-Google-Smtp-Source: ABdhPJwUEtutory+onldo0x1TGixN2zRXjY9H9kTOfyV/3nXFsbLE/x47ySFF9yVejeK5EGLipjhww== X-Received: by 2002:a05:6e02:5a3:: with SMTP id k3mr3856271ils.283.1631225783245; Thu, 09 Sep 2021 15:16:23 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id b19sm1543257ile.88.2021.09.09.15.16.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Sep 2021 15:16:22 -0700 (PDT) Subject: Re: [PATCH 13/19] cpupower: add the function to check amd-pstate enabled To: Huang Rui , "Rafael J . Wysocki" , Viresh Kumar , Borislav Petkov , Ingo Molnar , linux-pm@vger.kernel.org Cc: Deepak Sharma , Alex Deucher , Mario Limonciello , Nathan Fontenot , Jinzhou Su , Xiaojian Du , linux-kernel@vger.kernel.org, x86@kernel.org, Shuah Khan References: <20210908150001.3702552-1-ray.huang@amd.com> <20210908150001.3702552-14-ray.huang@amd.com> From: Shuah Khan Message-ID: <50412248-179d-3548-aeb0-d912a14a152f@linuxfoundation.org> Date: Thu, 9 Sep 2021 16:16:21 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210908150001.3702552-14-ray.huang@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/8/21 8:59 AM, Huang Rui wrote: > Introduce the cpupower_amd_pstate_enabled() to check whether the kernel > mode enables amd-pstate. > What does "kernel mode" mean? Are you referring to kernel vs. firmware mode? > Signed-off-by: Huang Rui > --- > tools/power/cpupower/utils/helpers/helpers.h | 5 +++++ > tools/power/cpupower/utils/helpers/misc.c | 20 ++++++++++++++++++++ > 2 files changed, 25 insertions(+) > > diff --git a/tools/power/cpupower/utils/helpers/helpers.h b/tools/power/cpupower/utils/helpers/helpers.h > index b4813efdfb00..eb43c14d1728 100644 > --- a/tools/power/cpupower/utils/helpers/helpers.h > +++ b/tools/power/cpupower/utils/helpers/helpers.h > @@ -136,6 +136,11 @@ extern int decode_pstates(unsigned int cpu, int boost_states, > > extern int cpufreq_has_boost_support(unsigned int cpu, int *support, > int *active, int * states); > + > +/* AMD PSTATE enabling **************************/ > + > +extern unsigned long cpupower_amd_pstate_enabled(unsigned int cpu); > + > /* > * CPUID functions returning a single datum > */ > diff --git a/tools/power/cpupower/utils/helpers/misc.c b/tools/power/cpupower/utils/helpers/misc.c > index fc6e34511721..07d80775fb68 100644 > --- a/tools/power/cpupower/utils/helpers/misc.c > +++ b/tools/power/cpupower/utils/helpers/misc.c > @@ -83,6 +83,26 @@ int cpupower_intel_set_perf_bias(unsigned int cpu, unsigned int val) > return 0; > } > > +unsigned long cpupower_amd_pstate_enabled(unsigned int cpu) > +{ > + char linebuf[MAX_LINE_LEN]; > + char path[SYSFS_PATH_MAX]; > + unsigned long val; > + char *endp; > + > + snprintf(path, sizeof(path), > + PATH_TO_CPU "cpu%u/cpufreq/is_amd_pstate_enabled", cpu); > + > + if (cpupower_read_sysfs(path, linebuf, MAX_LINE_LEN) == 0) > + return 0; > + > + val = strtoul(linebuf, &endp, 0); > + if (endp == linebuf || errno == ERANGE) > + return 0; > + > + return val; > +} > + > #endif /* #if defined(__i386__) || defined(__x86_64__) */ > > /* get_cpustate >