From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8YQu-0002UL-Ly for qemu-devel@nongnu.org; Mon, 03 Sep 2012 11:19:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T8YQp-0007Wi-Te for qemu-devel@nongnu.org; Mon, 03 Sep 2012 11:19:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60638) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8YQp-0007Uz-Kz for qemu-devel@nongnu.org; Mon, 03 Sep 2012 11:19:19 -0400 Message-ID: <5044CA2F.8000505@redhat.com> Date: Mon, 03 Sep 2012 17:18:07 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1346663926-20188-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1346663926-20188-5-git-send-email-xiawenc@linux.vnet.ibm.com> <5044BE96.7080701@redhat.com> In-Reply-To: <5044BE96.7080701@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, stefanha@gmail.com, aliguori@us.ibm.com, Wenchao Xia , qemu-devel@nongnu.org Il 03/09/2012 16:28, Eric Blake ha scritto: >> > +/* this file contains helper function used internally. */ >> > +#define SECTOR_SIZE (512) > Hard-coding this feels wrong, in this day and age of disks with 4096 > sectors. Why isn't this a per-image property? In this day and age of disks with 4096 sectors, Linux does not provide a way to query the required alignment for O_DIRECT... Paolo