From: Glauber Costa <glommer@parallels.com>
To: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>, Joonsoo Kim <js1304@gmail.com>,
linux-mm@kvack.org, David Rientjes <rientjes@google.com>
Subject: Re: C13 [13/14] Shrink __kmem_cache_create() parameter lists
Date: Mon, 3 Sep 2012 19:33:36 +0400 [thread overview]
Message-ID: <5044CDD0.4040403@parallels.com> (raw)
In-Reply-To: <00000139596cab81-8759391f-4d20-494a-9c7c-a759363e2b87-000000@email.amazonses.com>
On 08/24/2012 08:17 PM, Christoph Lameter wrote:
> -__kmem_cache_create (struct kmem_cache *cachep, const char *name, size_t size, size_t align,
> - unsigned long flags, void (*ctor)(void *))
> +__kmem_cache_create (struct kmem_cache *cachep, unsigned long flags)
> {
> size_t left_over, slab_size, ralign;
> gfp_t gfp;
> @@ -2385,9 +2383,9 @@ __kmem_cache_create (struct kmem_cache *
> * unaligned accesses for some archs when redzoning is used, and makes
> * sure any on-slab bufctl's are also correctly aligned.
> */
> - if (size & (BYTES_PER_WORD - 1)) {
> - size += (BYTES_PER_WORD - 1);
> - size &= ~(BYTES_PER_WORD - 1);
> + if (cachep->size & (BYTES_PER_WORD - 1)) {
> + cachep->size += (BYTES_PER_WORD - 1);
> + cachep->size &= ~(BYTES_PER_WORD - 1);
> }
There are still one reference to "size" inside this function that will
break the build. This reference is enclosed inside CONFIG_DEBUG.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-09-03 15:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120824160903.168122683@linux.com>
2012-08-24 16:10 ` C13 [05/14] Extract a common function for kmem_cache_destroy Christoph Lameter
2012-09-03 14:41 ` Glauber Costa
2012-09-03 15:26 ` Glauber Costa
2012-09-04 22:58 ` Christoph Lameter
2012-08-24 16:12 ` C13 [08/14] Get rid of __kmem_cache_destroy Christoph Lameter
2012-09-03 14:58 ` Glauber Costa
2012-09-04 22:39 ` Christoph Lameter
2012-09-05 8:25 ` Glauber Costa
2012-08-24 16:12 ` C13 [07/14] Move freeing of kmem_cache structure to common code Christoph Lameter
2012-09-03 14:51 ` Glauber Costa
2012-08-24 16:17 ` C13 [03/14] Improve error handling in kmem_cache_create Christoph Lameter
2012-09-03 14:30 ` Glauber Costa
2012-08-24 16:17 ` C13 [12/14] Move kmem_cache allocations into common code Christoph Lameter
2012-09-03 15:24 ` Glauber Costa
2012-08-24 16:17 ` C13 [11/14] Move sysfs_slab_add to common Christoph Lameter
2012-09-03 15:09 ` Glauber Costa
2012-08-24 16:17 ` C13 [04/14] Move list_add() to slab_common.c Christoph Lameter
2012-08-24 16:17 ` C13 [06/14] Always use the name "kmem_cache" for the slab cache with the kmem_cache structure Christoph Lameter
2012-08-24 16:17 ` C13 [10/14] Do slab aliasing call from common code Christoph Lameter
2012-08-24 16:17 ` C13 [01/14] slub: Add debugging to verify correct cache use on kmem_cache_free() Christoph Lameter
2012-09-03 14:26 ` Glauber Costa
2012-08-24 16:17 ` C13 [09/14] Move duping of slab name to slab_common.c Christoph Lameter
2012-09-03 15:02 ` Glauber Costa
2012-08-24 16:17 ` C13 [02/14] slub: Use kmem_cache for the kmem_cache structure Christoph Lameter
2012-09-03 14:27 ` Glauber Costa
2012-08-24 16:17 ` C13 [13/14] Shrink __kmem_cache_create() parameter lists Christoph Lameter
2012-09-03 15:33 ` Glauber Costa [this message]
2012-09-03 15:35 ` Glauber Costa
2012-09-04 22:48 ` Christoph Lameter
2012-08-24 16:17 ` C13 [14/14] Move kmem_cache refcounting to common code Christoph Lameter
2012-09-03 15:12 ` Glauber Costa
2012-09-04 19:10 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5044CDD0.4040403@parallels.com \
--to=glommer@parallels.com \
--cc=cl@linux.com \
--cc=js1304@gmail.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.