From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH] ACPI / blacklist: blacklist Win8 OSI for HP Pavilion dv6 Date: Tue, 17 Mar 2015 03:31:38 +0100 Message-ID: <5045126.GmAGs977fU@vostro.rjw.lan> References: <1425364754-31900-1-git-send-email-alex.hung@canonical.com> <1941299.sLe76u91Cr@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Return-path: Received: from v094114.home.net.pl ([79.96.170.134]:54832 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752002AbbCQCHq (ORCPT ); Mon, 16 Mar 2015 22:07:46 -0400 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Alex Hung Cc: Len Brown , Linux ACPI Mailing List , Hans de Goede , Aaron Lu On Saturday, March 14, 2015 08:46:25 PM Alex Hung wrote: > Rafael, > > Do you mean /sys/class/backlight/intel_backlight? It works but acpi_video fails. > > We have some cases that needs working acpi_video interfaces. I'd also > like to backport to previous kernels that has not use native backlight If backlight is the only reason, we don't add machines to blacklist.c any more. > On Wed, Mar 11, 2015 at 6:20 AM, Rafael J. Wysocki wrote: > > On Tuesday, March 03, 2015 02:39:14 PM Alex Hung wrote: > >> The brightness hotkeys of HP Pavilion dv6 does not work with Win8 OSI. Due > >> to insufficient documentation for the driver implementation, blacklist > >> it as a workaround. > > > > I gather that the native backlight interface doesn't work on those systems too, > > is that correct? > > > >> Signed-off-by: Alex Hung > >> --- > >> drivers/acpi/blacklist.c | 12 ++++++++++++ > >> 1 file changed, 12 insertions(+) > >> > >> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c > >> index 9b693d5..98aa360 100644 > >> --- a/drivers/acpi/blacklist.c > >> +++ b/drivers/acpi/blacklist.c > >> @@ -300,6 +300,18 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { > >> }, > >> > >> /* > >> + * The brightness hotkeys do not work on those machines when > >> + * returning true for _OSI("Windows 2012") > >> + */ > >> + { > >> + .callback = dmi_disable_osi_win8, > >> + .ident = "HP Pavilion dv6", > >> + .matches = { > >> + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > >> + DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv6 Notebook PC"), > >> + }, > >> + }, > >> + /* > >> * BIOS invocation of _OSI(Linux) is almost always a BIOS bug. > >> * Linux ignores it, except for the machines enumerated below. > >> */ > >> > > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.