From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37568) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8iSA-0005ga-4r for qemu-devel@nongnu.org; Mon, 03 Sep 2012 22:01:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T8iS8-0002wx-Vq for qemu-devel@nongnu.org; Mon, 03 Sep 2012 22:01:22 -0400 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:46824) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8iS8-0002vP-CR for qemu-devel@nongnu.org; Mon, 03 Sep 2012 22:01:20 -0400 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 4 Sep 2012 07:31:14 +0530 Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q84212qr24707128 for ; Tue, 4 Sep 2012 07:31:03 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q84211Gc020058 for ; Tue, 4 Sep 2012 12:01:02 +1000 Message-ID: <504560BC.1000506@linux.vnet.ibm.com> Date: Tue, 04 Sep 2012 10:00:28 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1346663926-20188-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1346663926-20188-3-git-send-email-xiawenc@linux.vnet.ibm.com> <5044AD13.5060205@redhat.com> In-Reply-To: <5044AD13.5060205@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 2/6] libqblock public type defines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, stefanha@gmail.com, aliguori@us.ibm.com, eblake@redhat.com, qemu-devel@nongnu.org 于 2012-9-3 21:13, Paolo Bonzini 写道: > Il 03/09/2012 11:18, Wenchao Xia ha scritto: >> +union QBlockOption_fmt { >> + struct QBlockOption_fmt_cow o_cow; >> + struct QBlockOption_fmt_qed o_qed; >> + struct QBlockOption_fmt_qcow o_qcow; >> + struct QBlockOption_fmt_qcow2 o_qcow2; >> + struct QBlockOption_fmt_raw o_raw; >> + struct QBlockOption_fmt_rbd o_rbd; >> + struct QBlockOption_fmt_sheepdog o_sheepdog; >> + struct QBlockOption_fmt_vdi o_vdi; >> + struct QBlockOption_fmt_vmdk o_vmdk; >> + struct QBlockOption_fmt_vpc o_vpc; >> +}; >> + >> +struct QBlockOptionFormat { >> + enum QBlockFormat fmt_type; >> + union QBlockOption_fmt fmt_op; >> + uint8_t reserved[512]; >> +}; > > Padding must be in the union not the struct. For the fourth time. > > Paolo > I must have left it in some other patches, sorry about this key point missing. -- Best Regards Wenchao Xia