From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment Date: Tue, 04 Sep 2012 11:32:22 +0300 Message-ID: <5045BC96.5070806@redhat.com> References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503C74DD.3020307@msgid.tls.msk.ru> <20120828172838.GD3661@redhat.com> <87fw76ak5l.fsf@codemonkey.ws> <878vcyrtlz.fsf@blackfin.pond.sub.org> <5044D75A.3000406@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Markus Armbruster , Anthony Liguori , "Michael S. Tsirkin" , kvm@vger.kernel.org, Marcelo Tosatti , Michael Tokarev , qemu-devel@nongnu.org, Alex Williamson , Jan Kiszka To: Blue Swirl Return-path: Received: from mx1.redhat.com ([209.132.183.28]:47032 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753667Ab2IDIcg (ORCPT ); Tue, 4 Sep 2012 04:32:36 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 09/03/2012 10:32 PM, Blue Swirl wrote: > On Mon, Sep 3, 2012 at 4:14 PM, Avi Kivity wrote: >> On 08/29/2012 11:27 AM, Markus Armbruster wrote: >>> >>> I don't see a point in making contributors avoid non-problems that might >>> conceivably become trivial problems some day. Especially when there's >>> no automated help with the avoiding. >> >> -Wpointer-arith > > +1 FWIW, I'm not in favour of enabling it, just pointing out that it exists. In general I prefer avoiding unnecessary use of extensions, but in this case the extension is trivial and improves readability. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8oYt-0008EJ-CZ for qemu-devel@nongnu.org; Tue, 04 Sep 2012 04:32:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T8oYj-0004KB-NT for qemu-devel@nongnu.org; Tue, 04 Sep 2012 04:32:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28569) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8oYj-0004K5-FB for qemu-devel@nongnu.org; Tue, 04 Sep 2012 04:32:33 -0400 Message-ID: <5045BC96.5070806@redhat.com> Date: Tue, 04 Sep 2012 11:32:22 +0300 From: Avi Kivity MIME-Version: 1.0 References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503C74DD.3020307@msgid.tls.msk.ru> <20120828172838.GD3661@redhat.com> <87fw76ak5l.fsf@codemonkey.ws> <878vcyrtlz.fsf@blackfin.pond.sub.org> <5044D75A.3000406@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcelo Tosatti , Michael Tokarev , Markus Armbruster , qemu-devel@nongnu.org, Alex Williamson , Jan Kiszka , Anthony Liguori On 09/03/2012 10:32 PM, Blue Swirl wrote: > On Mon, Sep 3, 2012 at 4:14 PM, Avi Kivity wrote: >> On 08/29/2012 11:27 AM, Markus Armbruster wrote: >>> >>> I don't see a point in making contributors avoid non-problems that might >>> conceivably become trivial problems some day. Especially when there's >>> no automated help with the avoiding. >> >> -Wpointer-arith > > +1 FWIW, I'm not in favour of enabling it, just pointing out that it exists. In general I prefer avoiding unnecessary use of extensions, but in this case the extension is trivial and improves readability. -- error compiling committee.c: too many arguments to function