From: Micha Nelissen <micha@neli.hopto.org>
To: Joakim Tjernlund <joakim.tjernlund@transmode.se>
Cc: netdev@vger.kernel.org
Subject: Re: Commit "ipconfig wait for carrier" makes boot hang for 2 mins if no carrier
Date: Wed, 05 Sep 2012 10:30:36 +0200 [thread overview]
Message-ID: <50470DAC.8030009@neli.hopto.org> (raw)
In-Reply-To: <OFFA3AC1B1.08FC3AAD-ONC1257A70.00266EDC-C1257A70.0026E8BC@transmode.se>
Op 2012-09-05 9:04, Joakim Tjernlund schreef:
>> Because that's where my root filesystem is? The IP autoconfiguration
>> code exists for this purpose.
>
> This is not the only purpose.
Documentation/filesystems/nfs/nfsroot.txt seems to suggest so (this is
where the ip= parameter is documented), but it works independently indeed.
So explain your reasons?
>>> The answer is probably the same, it is much easier to
>>> manage our IP config in one place for our embedded system.
>>
>> You retrieve the kernel via TFTP or so when booting?
>
> Yes, but mostly not. This really doesn't matter
Seems to me that if you boot standalone there is no reason to let the IP
address be configured by the kernel? Retrieve the IP address in user
space from your bootloader environment or whatever. And if you boot from
ethernet (or some other networking interface), then you have a carrier,
and there is no 2 minute delay (maybe less even than before with this
patch!).
>>> The wait should be conditional on NFS root or not so that non NFS roots
>>> can skip this stage altogether.
>
> Your patch broke other use cases so my patch would just revert or change the tmo
> to 2 secs or so.
> Or you could clean up your stuff so it works for all and not just for you.
It didn't break anything, it does work for you also, you just need to
wait somewhat longer. Or make sure there is a carrier. The intent of the
original 1 second delay was to let the link come up!
Micha
next prev parent reply other threads:[~2012-09-05 8:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 14:41 Commit "ipconfig wait for carrier" makes boot hang for 2 mins if no carrier Joakim Tjernlund
2012-09-04 16:09 ` Micha Nelissen
2012-09-04 18:04 ` Joakim Tjernlund
2012-09-04 19:33 ` Micha Nelissen
2012-09-05 7:04 ` Joakim Tjernlund
2012-09-05 8:30 ` Micha Nelissen [this message]
2012-09-05 8:47 ` Joakim Tjernlund
2012-09-05 17:01 ` David Miller
2012-09-05 21:41 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50470DAC.8030009@neli.hopto.org \
--to=micha@neli.hopto.org \
--cc=joakim.tjernlund@transmode.se \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.